Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: NetpuneLogger checkpoint saving reworked #19144

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Dec 12, 2023

What does this PR do?

  • NeptuneLogger will upload model checkpoints for best-K checkpoints without already uploaded ones -> Less data will be sent to Neptune server
  • Best K models will be resilient to local file deletions
  • Best model will not be duplicated and reuploaded
Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19144.org.readthedocs.build/en/19144/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 12, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #19144 (bf11a96) into master (df869c9) will decrease coverage by 34%.
Report is 2 commits behind head on master.
The diff coverage is 93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19144      +/-   ##
==========================================
- Coverage      83%      49%     -34%     
==========================================
  Files         443      435       -8     
  Lines       36764    36609     -155     
==========================================
- Hits        30617    17971   -12646     
- Misses       6147    18638   +12491     

@Raalsky Raalsky changed the title Draft: NetpuneLogger checkpoint saving reworked NetpuneLogger checkpoint saving reworked Dec 13, 2023
@mergify mergify bot removed the has conflicts label Dec 21, 2023
@Borda
Copy link
Member

Borda commented Jan 10, 2024

let's update or rebase after #19265 lands 🎏

Copy link

gitguardian bot commented Jan 16, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 78fa3af tests/tests_app/utilities/test_login.py View secret
- Base64 Basic Authentication 78fa3af tests/tests_app/utilities/test_login.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@mergify mergify bot added the has conflicts label Feb 1, 2024
@Raalsky Raalsky changed the title NetpuneLogger checkpoint saving reworked Draft: NetpuneLogger checkpoint saving reworked Feb 21, 2024
@Borda
Copy link
Member

Borda commented Mar 4, 2024

@Raalsky is it still a draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants