[WIP] Expand 64-bit edge support #148
Conversation
| @@ -8,12 +8,21 @@ | |||
| #ifndef KAFFPA_INTERFACE_RYEEZ6WJ | |||
| #define KAFFPA_INTERFACE_RYEEZ6WJ | |||
|
|
|||
| #include <stdint.h> | |||
| #include "kaHIP_config.h" | |||
There was a problem hiding this comment.
Minor, but perhaps this:
#include "kaHIP_config.h"
#ifdef __cplusplus
#include <cstdint>
extern "C"
{
#else
#include <stdint.h>
#endif
I'm always wary about including the C headers instead of C++ ones...
lib/tools/graph_communication.cpp
Outdated
| NodeID number_of_nodes = 0; | ||
| EdgeID number_of_edges = 0; | ||
|
|
||
| MPI_Datatype MNodeID = (sizeof(NodeID) == 4) ? MPI_INT : MPI_LONG_LONG; |
There was a problem hiding this comment.
why not MPI_INT32_T and MPI_INT64T instead?
|
These issues should be resolved. On the MPI side some more work will be needed when NodeID's are used rather than the current hybrid of int/NodeID's. As such the MPI datatype for the node remains as MPI_INT. |
What got my attention was the use of |
I think |
|
So I am not quite sure what to do on the Java side. I do not have a lot of familiarity with JNI and having the prototype change dynamically depending on how the library is compiled seems somewhat tricky. Does anyone have any suggestions here? |
|
sorry for the delay. I will have a look and provide feedback, it will just take a little while longer. |
This is a first pass at updating the public API to support 64-bit edges.
Note that lots of things are still broken, and I have not yet get around to the Java stuff. Proper support for MPI will require switching to the big-count interfaces which might bump the required MPI version. Going forwards I suspect that 64-bit node support will be required too (I currently routinely partition graphs with ~1.4B vertices). But this will require more changes (redefine NodeID, ensure consistent use, update header definitions).
Feedback would be appreciated.