Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64bit edges not reflected in the headers #41

Open
olesenm opened this issue Oct 28, 2019 · 12 comments
Open

64bit edges not reflected in the headers #41

olesenm opened this issue Oct 28, 2019 · 12 comments

Comments

@olesenm
Copy link

olesenm commented Oct 28, 2019

If I compile with 64bit edges, I'd expect a modified of the kaHIP_interface.h file to reflect this, but it only seems to be unaffected. The kaffpa() call uses int*

@schulzchristian
Copy link
Member

thanks, will integrate it with the next version.

@olesenm
Copy link
Author

olesenm commented Nov 12, 2019

Would it be possible/reasonable to define a typedef such as kahip_idxtype and possibly parkahip_idxtype in the headers. This would make it possible to extract some sizing information from the header and then compare this to the expectations. Eg, let us build a widening container for the indices and adjacency list. Could then always compile in 64bit and link with our 32-bit or 64-bit addressing.

@schulzchristian
Copy link
Member

Hey Mark, I am currently looking into this. Could you explain a little bit more what you need? Maybe I am able to integrate it in the current sprint.

@VoVAllen
Copy link

Hi,

I still meet this problem with the latest master branch. The type in kaHIP_interface.h is still int when compiling with 64BITMODE

@schulzchristian
Copy link
Member

Hi, I am happy if you issue a pull request.

@VoVAllen
Copy link

VoVAllen commented Dec 28, 2021

@schulzchristian I feel it's complicated. The signatures in https://github.com/KaHIP/KaHIP/blob/2158c5b6c07ae1b5755bcda6ea7adbca1a3618a2/interface/kaHIP_interface.cpp are all int. Is it safe to replace them with EdgeID or NodeID?

@olesenm
Copy link
Author

olesenm commented Dec 28, 2021

@VoVAllen nice that you are looking at this. I ran out of time to pursue it further...

@schulzchristian
Copy link
Member

I will look into it next week.

Best
Christian

@FreddieWitherden
Copy link

Along these lines if a typedef is added would it be possible to also add a function to query the size? Something like

int kahip_idx_size();

This is extremely useful for ABI purposes as it means given libkahip.so we do not need to guess what the index type size is. A good example of this is SCOTCH_numSizeof in SCOTCH which fulfils a similar role.

@schulzchristian
Copy link
Member

Hi @FreddieWitherden, I am happy to add this through a pull request.

@FreddieWitherden
Copy link

Perfect! I will work on something over the next few days and submit for feedback.

@FreddieWitherden
Copy link

First attempt at this is in #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants