Fix Windows double-adjustment of PATH
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On windows, `LIBPATH_env` == `"PATH"`, and we don't want to double-adjust `PATH`. We need to be careful around the `adjust_XXX` flags here, to ensure that if we don't want to adjust `LIBPATH` but do want to adjust `PATH` (as much as that makes sense on Windows) we only use the `PATH_list` and not the `LIBPATH_list`
staticfloat
force-pushed
the
sf/dont_adjust_twice
branch
from
408b89e
to
0f0bc20
Compare
|
For our own record, this is basically the same as JuliaPackaging/BinaryBuilder.jl#541, needed in particular by FFMPEG on Windows (throwing some keywords so that's easier to find the next time we'll need to do the same). |
giordano
reviewed
Oct 13, 2020
giordano
reviewed
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows,
LIBPATH_env=="PATH", and we don't want todouble-adjust
PATH.