Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sys.BINDIR to LIBPATH_list in JLL wrappers for Windows #541

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

giordano
Copy link
Member

@giordano giordano commented Dec 5, 2019

Honestly I'm a bit confused about how Julia-provided libraries are scattered around, to be sure I'm adding all possible directories. Ref JuliaGraphics/Gtk.jl#461.

@staticfloat
Copy link
Member

Hmmm, unclear why tests are failing. I'll try running locally.

Also, do we know why we keep on getting that "read-only filesystem" error? Is it because something isn't getting unmounted?

@giordano
Copy link
Member Author

giordano commented Dec 5, 2019

Also, do we know why we keep on getting that "read-only filesystem" error? Is it because something isn't getting unmounted?

I don't know, we're getting this quite often in Yggdrasil as well. But this is a recent thing, like one week or so, I've never seen this error locally

@staticfloat staticfloat mentioned this pull request Dec 5, 2019
@staticfloat
Copy link
Member

Try rebasing on top of master once #542 is merged. I think it should fix the issues here. (The issue being that ~/deps/downloads isn't being created for some reason)

@giordano giordano reopened this Dec 5, 2019
@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #541 into master will decrease coverage by 3.31%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
- Coverage   57.45%   54.14%   -3.32%     
==========================================
  Files          28       28              
  Lines        2769     2789      +20     
==========================================
- Hits         1591     1510      -81     
- Misses       1178     1279     +101
Impacted Files Coverage Δ
src/AutoBuild.jl 29.58% <0%> (-0.09%) ⬇️
src/DockerRunner.jl 0% <0%> (-88.24%) ⬇️
src/wizard/github.jl 27.27% <0%> (-10.23%) ⬇️
src/Rootfs.jl 52.19% <0%> (-3.85%) ⬇️
src/OutputCollector.jl 90.43% <0%> (-2.61%) ⬇️
src/squashfs_utils.jl 79.48% <0%> (-2.57%) ⬇️
src/Runner.jl 93.03% <0%> (-1%) ⬇️
src/BinaryBuilder.jl 43.07% <0%> (+0.21%) ⬆️
src/UserNSRunner.jl 76.88% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a2890...d81837c. Read the comment docs.

@staticfloat
Copy link
Member

bingo bango

@staticfloat staticfloat closed this Dec 5, 2019
@staticfloat staticfloat reopened this Dec 5, 2019
@staticfloat
Copy link
Member

.....darn GH interface jumping underneath my cursor.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants