syrk! and herk! are in the BLAS module #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- need to use the qualified names `BLAS.syrk!` and `BLAS.herk!` - a large block of code is inside `if VERSION < v"1.3.0-alpha.115` but `Project.toml` gives the minimum Julia version as 1.6 I think that block should be dropped but I don't know what your policy regarding dropping dead code is.
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 73.35% 73.35%
=======================================
Files 10 10
Lines 1670 1670
=======================================
Hits 1225 1225
Misses 445 445
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLAS.syrk!andBLAS.herk!if VERSION < v"1.3.0-alpha.115butProject.tomlgives the minimum Julia version as 1.6 I think that block should be dropped but I don't know what your policy regarding dropping dead code is.