Skip to content

Commit

Permalink
syrk! and herk! are in the BLAS module
Browse files Browse the repository at this point in the history
- need to use the qualified names `BLAS.syrk!` and `BLAS.herk!`
- a large block of code is inside `if VERSION < v"1.3.0-alpha.115` but `Project.toml` gives the minimum Julia version as 1.6  I think that block should be dropped but I don't know what your policy regarding dropping dead code is.
  • Loading branch information
dmbates committed Aug 28, 2022
1 parent d16065d commit 8b92c02
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/juliaBLAS.jl
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ Base.@deprecate rankUpdate!(α::Real, a::StridedVector, A::Hermitian) rankUpdate

# Rank k update
## Real
rankUpdate!(C::HermOrSym{T,S}, A::StridedMatrix{T}, α::T, β::T) where {T<:BlasReal,S<:StridedMatrix} = syrk!(C.uplo, 'N', α, A, β, C.data)
rankUpdate!(C::HermOrSym{T,S}, A::StridedMatrix{T}, α::T, β::T) where {T<:BlasReal,S<:StridedMatrix} = BLAS.syrk!(C.uplo, 'N', α, A, β, C.data)

## Complex
rankUpdate!(C::Hermitian{T,S}, A::StridedMatrix{Complex{T}}, α::T, β::T) where {T<:BlasReal,S<:StridedMatrix} = herk!(C.uplo, 'N', α, A, β, C.data)
rankUpdate!(C::Hermitian{T,S}, A::StridedMatrix{Complex{T}}, α::T, β::T) where {T<:BlasReal,S<:StridedMatrix} = BLAS.herk!(C.uplo, 'N', α, A, β, C.data)

### Generic
function rankUpdate!(C::Hermitian, A::StridedVecOrMat, α::Real)
Expand Down Expand Up @@ -84,7 +84,7 @@ end
Base.@deprecate rankUpdate!::Real, A::StridedVecOrMat, C::Hermitian) rankUpdate!(C, A, α)
Base.@deprecate rankUpdate!::Real, A::StridedVecOrMat, β::Real, C::Hermitian) rankUpdate!(C, A, α, β)

if VERSION < v"1.3.0-alpha.115"
if VERSION < v"1.3.0-alpha.115" # Project.toml has julia = "1.6" so this block should no longer be necessary
# BLAS style mul!
## gemv
mul!(y::StridedVector{T}, A::StridedMatrix{T}, x::StridedVector{T}, α::T, β::T) where {T<:BlasFloat} = gemv!('N', α, A, x, β, y)
Expand Down

0 comments on commit 8b92c02

Please sign in to comment.