beginswith, endswith accept Chars #6779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| beginswith(a::String, c::Char) = !isempty(a) && a[start(a)] == c | ||
|
|
||
| function beginswith(str::String, chars::Chars) | ||
| if !isempty(str) |
There was a problem hiding this comment.
How about !isempty(str) && str[start(str)] in chars && return true?
There was a problem hiding this comment.
very nice, I'll update
|
Done - I think that's good now |
|
Needs a doc update. Actually the docs for |
JeffBezanson
added a commit
that referenced
this pull request
May 13, 2014
beginswith, endswith accept Chars
|
Where did the documentation update go? |
|
I did it. |
|
Sorry, I found 57a0aa7 now :-) |
vtjnash
pushed a commit
that referenced
this pull request
Feb 10, 2024
Since Julia 0.3 (#6779), the `startswith` and `endswith` functions have accepted not only a string as the prefix/suffix, but also a character or a tuple/vector/set of characters. However, this wasn't fully documented. (The docstring actually mentioned vectors and sets of characters, but this was inconsistent with the given signature.) Also updates `Base.Chars` to allow `AbstractSet` types, not just `Set`, which seems to have been an oversight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
rstripand others acceptChars, it only seems fair ifendswith,beginswithdo the same.Consider trying to strip punctuation from the end of a sentence: