Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document Base.Chars arguments of startswith/endswith #52741

Merged
merged 5 commits into from
Feb 10, 2024
Merged

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Jan 4, 2024

Since Julia 0.3 (#6779), the startswith and endswith functions have accepted not only a string as the prefix/suffix, but also a character or a tuple/vector/set of characters. However, this wasn't fully documented.

(The docstring actually mentioned vectors and sets of characters, but this was inconsistent with the given signature.)

Also updates Base.Chars to allow AbstractSet types, not just Set, which seems to have been an oversight.

@stevengj stevengj added domain:docs This change adds or pertains to documentation domain:strings "Strings!" labels Jan 4, 2024
base/strings/util.jl Outdated Show resolved Hide resolved
base/strings/util.jl Outdated Show resolved Hide resolved
base/strings/util.jl Outdated Show resolved Hide resolved
@fingolfin fingolfin added the status:merge me PR is reviewed. Merge when all tests are passing label Feb 10, 2024
@vtjnash vtjnash merged commit 3a283d9 into master Feb 10, 2024
6 of 8 checks passed
@vtjnash vtjnash deleted the stevengj-patch-3 branch February 10, 2024 14:55
@inkydragon inkydragon removed the status:merge me PR is reviewed. Merge when all tests are passing label Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation domain:strings "Strings!"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants