Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also disable is_foldable test on other 32bit platforms #54910

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

IanButterworth
Copy link
Sponsor Member

@IanButterworth IanButterworth commented Jun 23, 2024

Follow-on from #54323

@aviatesk I think this should also be disabled on linux? It's been failing there

On test i686-linux-gnu

math                                              (7) |         failed at 2024-06-23T13:58:26.792
Test Failed at /cache/build/tester-amdci5-8/julialang/julia-buildkite/julia-2d4ef8a238/share/julia/test/math.jl:1607
  Expression: Core.Compiler.is_foldable(effects)
     Context: effects = (+c,+e,+n,!t,+s,+m,+u,+o)
              T = Float64

@oscardssmith
Copy link
Member

which of the functions isn't inferring correctly? we probably do want the basic math to infer correctly on 32 but systems

@IanButterworth
Copy link
Sponsor Member Author

This is the test

julia/test/math.jl

Lines 1605 to 1609 in 696d9c3

@static if !(Sys.iswindows()&&Int==Int32) # COMBAK debug this
@testset let effects = Base.infer_effects(^, (T,Int))
@test Core.Compiler.is_foldable(effects)
end
end # @static

@IanButterworth
Copy link
Sponsor Member Author

IanButterworth commented Jun 24, 2024

Basically I'm proposing that given the comment that was on this test, we merge this so that we can merge the buildkite change and the issue can be addressed in due course per the comment.

@oscardssmith
Copy link
Member

interesting...

Copy link
Sponsor Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugging this kind of issue is very troublesome without easy access to a 32-bit systems, so I think it's okay to disable it for now.

@aviatesk aviatesk merged commit f846b89 into JuliaLang:master Jun 24, 2024
9 checks passed
@IanButterworth IanButterworth deleted the ib/is_foldable_disable branch June 24, 2024 10:04
@oscardssmith
Copy link
Member

so launching 32 bit Julia (1.10.4) on a 64 bit linux machine doesn't reproduce this...

@IanButterworth
Copy link
Sponsor Member Author

Try a nightly?

@oscardssmith
Copy link
Member

grr. Cthulhu is broken on nightly...

oscardssmith added a commit that referenced this pull request Jun 26, 2024
fixes #54910 properly.

The recursion heuristic was getting mad at this for some reason...
@aviatesk
Copy link
Sponsor Member

Cthulhu is broken on nightly...

Is it really broken? [email protected] seems to be working fine on master.

@oscardssmith
Copy link
Member

ah I had an outdated version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants