Do not let public unexport names
#52814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Jan 8, 2024
LilithHafner
added
the
status:merge me
LilithHafner
removed
the
status:merge me
|
Perhaps it should error instead? |
|
Seems like a good idea. This also raises the question: should duplicate exports error/warn, should duplicate public statements error/warn, and should public followed by export error/warn? The latter two can be done now in a non-breaking way. |
|
We have to backport or this is breaking. |
60 tasks
|
This was merged before branching so this commit already exists on |
KristofferC
removed
the
backport 1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52812
(shoutout to caching in the build process: rebuilding Julia from source to test this change was very fast)