Do not let public unexport names (#52814)

JuliaLang · Jan 8, 2024 · 486f434 · 486f434
1 parent b354ce7
commit 486f434
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/module.c b/src/module.c
@@ -667,7 +667,7 @@ JL_DLLEXPORT void jl_module_public(jl_module_t *from, jl_sym_t *s, int exported)
 {
  jl_binding_t *b = jl_get_module_binding(from, s, 1);
  b->publicp = 1;
- b->exportp = exported;
+ b->exportp |= exported;
 }
 
 JL_DLLEXPORT int jl_boundp(jl_module_t *m, jl_sym_t *var)

diff --git a/test/reflection.jl b/test/reflection.jl
@@ -1180,3 +1180,15 @@ let (src, rt) = only(code_typed(sub2ind_gen, (NTuple,Int,Int,); optimize=false))
  @test any(iscall((src,sub2ind_gen_fallback)), src.code)
  @test any(iscall((src,error)), src.code)
 end
+
+# marking a symbol as public should not "unexport" it
+# https://github.com/JuliaLang/julia/issues/52812
+module Mod52812
+export a, b
+public a
+end
+
+@test Base.isexported(Mod52812, :a)
+@test Base.isexported(Mod52812, :b)
+@test Base.ispublic(Mod52812, :a)
+@test Base.ispublic(Mod52812, :b)