Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable naming confusion in warn_if_already_loaded_different() #52778

Merged
merged 1 commit into from
Jan 6, 2024

Commits on Jan 6, 2024

  1. Fix variable naming confusion in warn_if_already_loaded_different()

    Without this, it is possible to run into an error that looks like:
    
    ```
    ERROR: LoadError: UndefVarError: `v` not defined in local scope
    Suggestion: check for an assignment to a local variable that shadows a
    global of the same name.
    Stacktrace:
      [1] warn_if_already_loaded_different(uuidkey::Base.PkgId)
        @ Base ./loading.jl:1998
      [2] __require_prelocked(uuidkey::Base.PkgId, env::String)
        @ Base ./loading.jl:1980
      [3] #invoke_in_world#3
        @ Base ./essentials.jl:989 [inlined]
      [4] invoke_in_world
        @ Base ./essentials.jl:986 [inlined]
      [5] _require_prelocked
        @ Base ./loading.jl:1962 [inlined]
      [6] macro expansion
        @ Base ./loading.jl:1900 [inlined]
      [7] macro expansion
        @ Base ./lock.jl:269 [inlined]
      [8] __require(into::Module, mod::Symbol)
        @ Base ./loading.jl:1861
      [9] #invoke_in_world#3
        @ Base ./essentials.jl:989 [inlined]
     [10] invoke_in_world
        @ Base ./essentials.jl:986 [inlined]
     [11] require(into::Module, mod::Symbol)
        @ Base ./loading.jl:1854
    ```
    staticfloat committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    bddb9f7 View commit details
    Browse the repository at this point in the history