Fix variable naming confusion in warn_if_already_loaded_different()
#52778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, it is possible to run into an error that looks like:
```
ERROR: LoadError: UndefVarError: `v` not defined in local scope
Suggestion: check for an assignment to a local variable that shadows a
global of the same name.
Stacktrace:
[1] warn_if_already_loaded_different(uuidkey::Base.PkgId)
@ Base ./loading.jl:1998
[2] __require_prelocked(uuidkey::Base.PkgId, env::String)
@ Base ./loading.jl:1980
[3] #invoke_in_world#3
@ Base ./essentials.jl:989 [inlined]
[4] invoke_in_world
@ Base ./essentials.jl:986 [inlined]
[5] _require_prelocked
@ Base ./loading.jl:1962 [inlined]
[6] macro expansion
@ Base ./loading.jl:1900 [inlined]
[7] macro expansion
@ Base ./lock.jl:269 [inlined]
[8] __require(into::Module, mod::Symbol)
@ Base ./loading.jl:1861
[9] #invoke_in_world#3
@ Base ./essentials.jl:989 [inlined]
[10] invoke_in_world
@ Base ./essentials.jl:986 [inlined]
[11] require(into::Module, mod::Symbol)
@ Base ./loading.jl:1854
```
|
@ven-k I think this is actually the fundamental error we were seeing. |
|
Nice catch. This must be it. |
IanButterworth
approved these changes
Jan 6, 2024
IanButterworth
added
the
status:merge me
IanButterworth
added a commit
to IanButterworth/julia
that referenced
this pull request
Jan 7, 2024
…erent()` (JuliaLang#52778)" This reverts commit c827094.
IanButterworth
removed
the
status:merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, it is possible to run into an error that looks like: