-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public keyword #50105
Merged
Merged
Add public keyword #50105
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
5b3d8c1
mwe including `export (scoped-true), a, b, c` and `names`
665855e
add `Base.isinternal` and use it to flag internal methods in their do…
52f519e
update documentation
03f9e02
add more verbose clarificaiton of what is and is not public API (TODO…
7eb64a2
add prelimianry list of scoped-exported symbols for review
c7192ea
more docs (implement option 1 of https://github.com/JuliaLang/julia/p…
ec3b2f3
address @jariji's comments
804f5ef
Merge branch 'master' into scoped-export
LilithHafner 7d404f0
Merge branch 'master' into scoped-export
4dc10c4
use JuliaSyntax#320 branch
5fd1f64
bump JuliaSyntax
b85ae46
more changes for scoped export -> public
acc928a
try to make public list functional
a5162c2
bump juliasyntax
aacc187
bump JuliaSyntax
145ad7f
fix lowering
aea3d22
clarify internal symbol warning and add test for it
f7d57ba
add test for names + public
34844bb
don't autocomplete internals (ideally we _would_ autocomplete interna…
8241760
Merge branch 'master' into scoped-export
920244a
update FAQ (this change introduces comedy and therefore may be contro…
9e61f96
Rename isinternal to ispublic and make all resolved symbols in Main p…
f75cb68
fix typo in test/reflection.jl
db7ba05
change module docstring warning
7dbdd5e
Make warning an Admonition
ac11ea4
bump JuliaSyntax
bd0ee87
fix doc tests
1dc9652
remove internal warning tests from stdlib/REPL/test/docview.jl becaus…
17b8834
restore autocomplete for non-public symbols
6e2ddec
Merge branch 'master' into scoped-export
LilithHafner 1000988
initialize public to false (woops!)
c5955c0
more fixups for doc tests
5ed2c7d
remove joke
5da758e
fix repl tests
de8be2b
fix precompile tests
d75725b
bump juliasyntax to merged version
05352df
Make `compilecache` internal
LilithHafner 4b04f31
Remove `_datatype_*` publics
LilithHafner 051f824
Remove symbols from public list
LilithHafner 8a56ab4
Add some modules to public list (@vtjnash)
LilithHafner 6e2d809
remove newlines between bullet points
69cf8d4
Apply suggestions from code review
LilithHafner 9d74beb
Apply suggestions from code review
LilithHafner 4b18e1d
Merge branch 'master' into scoped-export
4ba71ab
add show tests
ce3a798
group public symbols a little better
ca8eb44
revert names to the most basic implementation (simply swap export=>pu…
6d1e2c7
fix typo
2678523
fix typo
528469b
revert unnecessary whitespace change
082fb86
add tests for ispublic and add more tests for isexported
3d09dae
fix some tests
12bab72
Do a better job of logging nonpublic access in help mode
0112e2c
remove obsolete tests
66427c6
finalize struct
067d69c
update tests
b688b60
add tests and fix "public names" header
6ce6fdb
update documentation throughout to refer to public and export now-cor…
e57c63f
fix cross refs
1a6e3dc
update varinfo documentation
ebcdf24
Merge branch 'master' into scoped-export
LilithHafner d4418fe
Update checksums
c4924c9
fix some tests
5835699
more test fixes
153b538
try switching to a different JuliaSyntax version
158d59f
don't accidentally drop the module in testing
41f3729
fix some doctests
fd5fb90
Merge branch 'master' into scoped-export
LilithHafner ea7a141
Docstring fixup for Base.ispublic
LilithHafner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix cross refs
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo ("available available")?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#51334