Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public keyword #50105
Add public keyword #50105
Changes from 1 commit
5b3d8c1
665855e
52f519e
03f9e02
7eb64a2
c7192ea
ec3b2f3
804f5ef
7d404f0
4dc10c4
5fd1f64
b85ae46
acc928a
a5162c2
aacc187
145ad7f
aea3d22
f7d57ba
34844bb
8241760
920244a
9e61f96
f75cb68
db7ba05
7dbdd5e
ac11ea4
bd0ee87
1dc9652
17b8834
6e2ddec
1000988
c5955c0
5ed2c7d
5da758e
de8be2b
d75725b
05352df
4b04f31
051f824
8a56ab4
6e2d809
69cf8d4
9d74beb
4b18e1d
4ba71ab
ce3a798
ca8eb44
6d1e2c7
2678523
528469b
082fb86
3d09dae
12bab72
0112e2c
66427c6
067d69c
b688b60
6ce6fdb
e57c63f
1a6e3dc
ebcdf24
d4418fe
c4924c9
5835699
153b538
158d59f
41f3729
fd5fb90
ea7a141
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly it's a joke, an alternative to "it's not", and also what I would consider a reasonable estimate unless we come out with a mostly non-breaking 2.0 much sooner, which is more likely.
In any event, "When is Julia 2.0 coming out?" is frequently asked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. I added it because of
https://github.com/JuliaLang/julia/pull/50105/files#diff-3591da1fafe13d9fcae96e5b32a9492c6fb68b7e33ac0810b106b09b45d59534R49-R50