Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark and light images for README.md #49544

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

cormullion
Copy link
Contributor

This PR adds two images to the README.md of this repo, responding to Github dark and light modes. Github description of the feature here.

They should look like this:

Screenshot 2023-04-27 at 17 09 23

In an earlier PR (#39601) a white line was added, but it looked a bit out of balance to me.

(This is a restrained and simple design to keep the file size down... 😂)

@aviks aviks merged commit 8a16d2f into JuliaLang:master Apr 27, 2023
@KristofferC
Copy link
Sponsor Member

It's very big, no?

@cormullion
Copy link
Contributor Author

It's very big, no?

39 Kb ? - quite small, especially for me. I think the contributor avatars are bigger ...

@ViralBShah
Copy link
Member

ViralBShah commented Apr 27, 2023

I thought Kristoffer was referring to it being big visually. It seems fine to me - but in my dark browser, I still see the white version.

@giordano
Copy link
Contributor

but in my dark browser, I still see the white version.

Try to clear the cache, I had the same problem at first.

@cormullion
Copy link
Contributor Author

to it being big visually

Ah, OK, yes - I just went for social-media-preview size... 🤷‍♂️

I think cacheing may be a thing - I hope github's code works 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants