methodshow: single-line printing for Method by default
#46241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this impact printing of e.g. |
No, those printings won't be affected by this PR> |
Currently `show(::IO, ::Method)` prints the method object in
multiple-line as like:
```julia
julia> only(methods(sin, (Float64,)))
sin(x::T) where T<:Union{Float32, Float64}
@ Base.Math special/trig.jl:29
```
and this could be confusing when used within a container e.g.:
```julia
julia> Any[only(methods(sin, (Float64,)))]
1-element Vector{Any}:
sin(x::T) where T<:Union{Float32, Float64}
@ Base.Math special/trig.jl:29
julia> code_lowered() do; Base.Experimental.@opaque a::Int -> sin(a); end
1-element Vector{Core.CodeInfo}:
CodeInfo(
1 ─ %1 = Core.apply_type(Core.Tuple, Main.Int)
│ %2 = Core.apply_type(Core.Union)
│ %3 = $(Expr(:new_opaque_closure, :(%1), :(%2), :(Core.Any), opaque closure(...)
@ Main none:0))
└── return %3
)
```
This commit refactors the `show` method for `Method` object so that
`show(::IO, ::Method)` prints it within a single line by default and
`show(::IO, ::MIME"text/plain", ::Method)` prints within 2-lines,
that I believe is more aligned with printing implementations for
the other types:
```julia
julia> Any[only(methods(sin, (Float64,)))]
1-element Vector{Any}:
sin(x::T) where T<:Union{Float32, Float64} @ Base.Math special/trig.jl:29
julia> code_lowered() do; Base.Experimental.@opaque a::Int -> sin(a); end
1-element Vector{Core.CodeInfo}:
CodeInfo(
1 ─ %1 = Core.apply_type(Core.Tuple, Main.Int)
│ %2 = Core.apply_type(Core.Union)
│ %3 = $(Expr(:new_opaque_closure, :(%1), :(%2), :(Core.Any), opaque closure(...) @ Main none:0))
└── return %3
)
```
aviatesk
force-pushed
the
avi/methodshow
branch
from
ed84454
to
3f33e68
Compare
|
CI looks fine. Are there any objections? Otherwise I'd merge this soonish. |
|
Yeah, looks good to me! Thank you as well for cleaning up the indentation numbers being passed around :) |
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
…6241) Currently `show(::IO, ::Method)` prints the method object in multiple-line as like: ```julia julia> only(methods(sin, (Float64,))) sin(x::T) where T<:Union{Float32, Float64} @ Base.Math special/trig.jl:29 ``` and this could be confusing when used within a container e.g.: ```julia julia> Any[only(methods(sin, (Float64,)))] 1-element Vector{Any}: sin(x::T) where T<:Union{Float32, Float64} @ Base.Math special/trig.jl:29 julia> code_lowered() do; Base.Experimental.@opaque a::Int -> sin(a); end 1-element Vector{Core.CodeInfo}: CodeInfo( 1 ─ %1 = Core.apply_type(Core.Tuple, Main.Int) │ %2 = Core.apply_type(Core.Union) │ %3 = $(Expr(:new_opaque_closure, :(%1), :(%2), :(Core.Any), opaque closure(...) @ Main none:0)) └── return %3 ) ``` This commit refactors the `show` method for `Method` object so that `show(::IO, ::Method)` prints it within a single line by default and `show(::IO, ::MIME"text/plain", ::Method)` prints within 2-lines, that I believe is more aligned with printing implementations for the other types: ```julia julia> Any[only(methods(sin, (Float64,)))] 1-element Vector{Any}: sin(x::T) where T<:Union{Float32, Float64} @ Base.Math special/trig.jl:29 julia> code_lowered() do; Base.Experimental.@opaque a::Int -> sin(a); end 1-element Vector{Core.CodeInfo}: CodeInfo( 1 ─ %1 = Core.apply_type(Core.Tuple, Main.Int) │ %2 = Core.apply_type(Core.Union) │ %3 = $(Expr(:new_opaque_closure, :(%1), :(%2), :(Core.Any), opaque closure(...) @ Main none:0)) └── return %3 ) ```
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
…6241) Currently `show(::IO, ::Method)` prints the method object in multiple-line as like: ```julia julia> only(methods(sin, (Float64,))) sin(x::T) where T<:Union{Float32, Float64} @ Base.Math special/trig.jl:29 ``` and this could be confusing when used within a container e.g.: ```julia julia> Any[only(methods(sin, (Float64,)))] 1-element Vector{Any}: sin(x::T) where T<:Union{Float32, Float64} @ Base.Math special/trig.jl:29 julia> code_lowered() do; Base.Experimental.@opaque a::Int -> sin(a); end 1-element Vector{Core.CodeInfo}: CodeInfo( 1 ─ %1 = Core.apply_type(Core.Tuple, Main.Int) │ %2 = Core.apply_type(Core.Union) │ %3 = $(Expr(:new_opaque_closure, :(%1), :(%2), :(Core.Any), opaque closure(...) @ Main none:0)) └── return %3 ) ``` This commit refactors the `show` method for `Method` object so that `show(::IO, ::Method)` prints it within a single line by default and `show(::IO, ::MIME"text/plain", ::Method)` prints within 2-lines, that I believe is more aligned with printing implementations for the other types: ```julia julia> Any[only(methods(sin, (Float64,)))] 1-element Vector{Any}: sin(x::T) where T<:Union{Float32, Float64} @ Base.Math special/trig.jl:29 julia> code_lowered() do; Base.Experimental.@opaque a::Int -> sin(a); end 1-element Vector{Core.CodeInfo}: CodeInfo( 1 ─ %1 = Core.apply_type(Core.Tuple, Main.Int) │ %2 = Core.apply_type(Core.Union) │ %3 = $(Expr(:new_opaque_closure, :(%1), :(%2), :(Core.Any), opaque closure(...) @ Main none:0)) └── return %3 ) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
show(::IO, ::Method)prints the method object inmultiple-line as like:
and this could be confusing when used within a container e.g.:
This commit refactors the
showmethod forMethodobject so thatshow(::IO, ::Method)prints it within a single line by default andshow(::IO, ::MIME"text/plain", ::Method)prints within 2-lines,that I believe is more aligned with printing implementations for
the other types:
/cc @Seelengrab