Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout of REPL completions with newlines #45844

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

Liozou
Copy link
Member

@Liozou Liozou commented Jun 28, 2022

Fix #45836 by forcing REPL completions that include a newline to print on a single column.

The behaviour on this PR is like for a small terminal:

julia> include(<tab>
include(mapexpr::Function, fname::AbstractString)
     @ Base.MainInclude client.jl:469
include(fname::AbstractString)
     @ Base.MainInclude client.jl:470

I didn't know how to test this so feel free to comment if you think the test can be improved.

@Liozou Liozou force-pushed the fixcompletionlayoutnewline branch 3 times, most recently from 3d332e2 to 380c397 Compare June 29, 2022 08:09
@Liozou Liozou force-pushed the fixcompletionlayoutnewline branch 2 times, most recently from d376108 to fb32afa Compare July 7, 2022 08:42
stdlib/REPL/src/LineEdit.jl Outdated Show resolved Hide resolved
@Liozou Liozou force-pushed the fixcompletionlayoutnewline branch 2 times, most recently from ace2fac to ac50a86 Compare July 7, 2022 22:02
@Liozou
Copy link
Member Author

Liozou commented Jul 12, 2022

CI failure looks like #45310 and #45981, which should be unrelated.

@Liozou Liozou added the stdlib:REPL Julia's REPL (Read Eval Print Loop) label Jul 30, 2022
@KristofferC
Copy link
Sponsor Member

I think this is fixed by #46241, shout otherwise :)

@Liozou Liozou deleted the fixcompletionlayoutnewline branch August 30, 2022 15:06
@Liozou Liozou restored the fixcompletionlayoutnewline branch August 30, 2022 15:06
@Liozou Liozou deleted the fixcompletionlayoutnewline branch August 30, 2022 15:06
@vtjnash
Copy link
Sponsor Member

vtjnash commented Aug 30, 2022

I think this is still merge-worthy. Not specifically needed for that case any more, but any other random user might come along and use the REPLCompletions code and expect this case to work.

@vtjnash vtjnash added the status:merge me PR is reviewed. Merge when all tests are passing label Aug 30, 2022
@Liozou Liozou restored the fixcompletionlayoutnewline branch August 31, 2022 09:26
@DilumAluthge DilumAluthge reopened this Sep 3, 2022
@DilumAluthge DilumAluthge merged commit 61b5a08 into JuliaLang:master Sep 6, 2022
@DilumAluthge DilumAluthge removed the status:merge me PR is reviewed. Merge when all tests are passing label Sep 6, 2022
@Liozou Liozou deleted the fixcompletionlayoutnewline branch January 3, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib:REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REPL] broken tab completion layout for methods
4 participants