Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copyto! fix for BitArray/AbstractArray #46161

Merged
merged 3 commits into from
Jul 25, 2022
Merged

copyto! fix for BitArray/AbstractArray #46161

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a333458
Fix 5-args `copyto!` for `BitArray`/`AbstractArray`
N5N3 Jul 25, 2022
c665a86
add missing check.
N5N3 Jul 25, 2022
4692f16
move offset check to the top
N5N3 Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add missing check.
  • Loading branch information
@N5N3
N5N3 committed Jul 25, 2022
commit c665a86ba35b46e2f4bd6ea7eceafdc33745600d
1 change: 1 addition & 0 deletions base/bitarray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ copyto!(dest::BitArray, doffs::Integer, src::Union{BitArray,Array}, soffs::Integ
_copyto_int!(dest, Int(doffs), src, Int(soffs), Int(n))
function _copyto_int!(dest::BitArray, doffs::Int, src::Union{BitArray,Array}, soffs::Int, n::Int)
n == 0 && return dest
n < 0 && throw(ArgumentError("Number of elements to copy must be nonnegative."))
soffs < 1 && throw(BoundsError(src, soffs))
doffs < 1 && throw(BoundsError(dest, doffs))
soffs+n-1 > length(src) && throw(BoundsError(src, length(src)+1))
Expand Down