copyto! fix for BitArray/AbstractArray
#46161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N5N3
added
domain:arrays
1. map `copyto!(::BitArray, n1, ::BitArray, n2, l)` to `Base.unsafe_copyto!` 2. add missing unaliasing in `copyto!` for `AbstractArray`
fredrikekre
reviewed
Jul 25, 2022
KristofferC
pushed a commit
that referenced
this pull request
Aug 6, 2022
32 tasks
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
…uliaLang#46161) 1. map `copyto!(::BitArray, n1, ::BitArray, n2, l)` to `Base.unsafe_copyto!` 2. add missing unaliasing in `copyto!` for `AbstractArray`
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
…uliaLang#46161) 1. map `copyto!(::BitArray, n1, ::BitArray, n2, l)` to `Base.unsafe_copyto!` 2. add missing unaliasing in `copyto!` for `AbstractArray`
78 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
KristofferC
pushed a commit
that referenced
this pull request
Dec 21, 2022
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
This was referenced May 16, 2023
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #25968 via dispatching
copyto!toBase.unsafe_copyto!Also the missing aliasing check is added to the general fallback for
AbstractArray.Test added.