Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark two_mul as consistent #46022

Merged
merged 2 commits into from
Jul 15, 2022
Merged

mark two_mul as consistent #46022

merged 2 commits into from
Jul 15, 2022

Conversation

oscardssmith
Copy link
Member

should let the compiler prove that float64^int always gives the same result.

@oscardssmith
mark two_mul as consistent
4e736b7 
should let the compiler prove that float64^int always gives the same result.
@oscardssmith oscardssmith added performance Must go faster domain:maths Mathematical functions labels Jul 13, 2022
@oscardssmith oscardssmith requested a review from Keno July 13, 2022 15:44
@mikmoore mikmoore mentioned this pull request Jul 13, 2022
Closed
aviatesk
aviatesk reviewed Jul 13, 2022
View reviewed changes
Copy link
Sponsor Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test cases that make sure this improvement doesn't regress? Something like what done in 96a70e3.

@oscardssmith oscardssmith mentioned this pull request Jul 14, 2022
Merged
@aviatesk
Copy link
Sponsor Member

The doctest failure is unrelated and fixed by #46021.

@aviatesk aviatesk merged commit fd70eab into master Jul 15, 2022
@aviatesk aviatesk deleted the oscardssmith-consistent-two_mul branch July 15, 2022 04:39
@aviatesk
Copy link
Sponsor Member

The doctest failure is unrelated and fixed by #46021.

@KristofferC
Copy link
Sponsor Member

Fixed #45949?

@KristofferC KristofferC added the backport 1.8 Change should be backported to release-1.8 label Jul 19, 2022
@KristofferC KristofferC mentioned this pull request Jul 20, 2022
Merged
32 tasks
KristofferC pushed a commit that referenced this pull request Jul 20, 2022
@oscardssmith
mark two_mul as consistent (#46022)
d6e8e5d 
should let the compiler prove that float64^int always gives the same result.

(cherry picked from commit fd70eab)
@aviatesk aviatesk removed the backport 1.8 Change should be backported to release-1.8 label Jul 26, 2022
ffucci pushed a commit to ffucci/julia that referenced this pull request Aug 11, 2022
@oscardssmith
mark two_mul as consistent (JuliaLang#46022)
d28ed55 
should let the compiler prove that float64^int always gives the same result.
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
@oscardssmith @pcjentsch
mark two_mul as consistent (JuliaLang#46022)
3a5e711 
should let the compiler prove that float64^int always gives the same result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

@aviatesk aviatesk aviatesk approved these changes

Assignees
No one assigned
Labels
domain:maths Mathematical functions performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oscardssmith @aviatesk @KristofferC @Keno