Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: fix PATH set #45957

Merged
merged 9 commits into from
Jul 22, 2022
Merged

Makefile: fix PATH set #45957

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9ecca90
Makefile: fix shell cmd call
inkydragon Jul 7, 2022
39be196
Makefile: fix `PATH` set on cygwin
inkydragon Jul 7, 2022
f219160
Update Makefile
inkydragon Jul 8, 2022
00ef201
Merge branch 'master' into cygwin-path-set
inkydragon Jul 9, 2022
3617a41
Merge branch 'master' into cygwin-path-set
inkydragon Jul 14, 2022
1101f50
Merge branch 'master' into cygwin-path-set
inkydragon Jul 15, 2022
ef587bb
Merge branch 'master' into cygwin-path-set
inkydragon Jul 16, 2022
69758f7
Merge branch 'master' into cygwin-path-set
inkydragon Jul 21, 2022
aeccabd
Merge branch 'master' into cygwin-path-set
inkydragon Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Makefile: fix PATH set on cygwin 
There may be spaces in the `PATH`
  • Loading branch information
@inkydragon
inkydragon committed Jul 7, 2022
commit 39be1968246f69201d74de02cde8869055fcff77
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ check-whitespace:
ifneq ($(NO_GIT), 1)
@# Append the directory containing the julia we just built to the end of `PATH`,
@# to give us the best chance of being able to run this check.
@PATH=$(PATH):$(shell dirname $(JULIA_EXECUTABLE)) $(JULIAHOME)/contrib/check-whitespace.jl
@PATH="$(PATH):$(shell dirname $(JULIA_EXECUTABLE))" $(JULIAHOME)/contrib/check-whitespace.jl
inkydragon marked this conversation as resolved.
Show resolved Hide resolved
else
$(warn "Skipping whitespace check because git is unavailable")
endif
Expand Down