Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: fix PATH set #45957

Merged
merged 9 commits into from
Jul 22, 2022
Merged

Makefile: fix PATH set #45957

merged 9 commits into from
Jul 22, 2022

Conversation

inkydragon
Copy link
Sponsor Member

@inkydragon inkydragon commented Jul 7, 2022

  • dirname is a shell command
  • There may be spaces in PATH on cygwin

@inkydragon inkydragon added the domain:building Build system, or building Julia or its dependencies label Jul 7, 2022
Makefile Outdated Show resolved Hide resolved
inkydragon added a commit to inkydragon/julia that referenced this pull request Jul 16, 2022
@inkydragon inkydragon requested a review from vtjnash July 22, 2022 14:13
@vtjnash vtjnash merged commit 9bdaabd into JuliaLang:master Jul 22, 2022
@inkydragon inkydragon deleted the cygwin-path-set branch July 23, 2022 02:14
ffucci pushed a commit to ffucci/julia that referenced this pull request Aug 11, 2022
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
inkydragon added a commit to inkydragon/julia that referenced this pull request Feb 13, 2023
inkydragon added a commit to inkydragon/julia that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants