Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 fix bus error on smaller readonly file in unix #44354

Merged
merged 10 commits into from
Aug 21, 2023
Merged

馃悰 fix bus error on smaller readonly file in unix #44354

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c9e56d4
馃悰 fix bus error on smaller readonly file in unix
xgdgsc Feb 26, 2022
10588f3
Update stdlib/Mmap/src/Mmap.jl
xgdgsc Feb 26, 2022
de9c375
Update stdlib/Mmap/src/Mmap.jl
xgdgsc Mar 1, 2022
b8bb51b
logic cleanup
xgdgsc Mar 1, 2022
b7829c9
Apply suggestions from code review
vtjnash Nov 8, 2022
015812f
馃悰 try fix ci fail
xgdgsc Jan 12, 2023
bc0cdaa
Update stdlib/Mmap/src/Mmap.jl
xgdgsc Jan 13, 2023
8b02ca4
try skip for 馃崕
xgdgsc Jul 15, 2023
67bab23
try keep old behaviror for 馃崕
xgdgsc Jul 15, 2023
fe71de3
Merge branch 'master' into xgdgsc-patch-1
xgdgsc Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
馃悰 fix bus error on smaller readonly file in unix
  • Loading branch information
@xgdgsc @vtjnash
xgdgsc authored and vtjnash committed Jul 18, 2023
commit c9e56d48445c78cdfdfdd9296ad195275ee2178d
1 change: 1 addition & 0 deletions stdlib/Mmap/src/Mmap.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ function mmap(io::IO,
@static if Sys.isunix()
prot, flags, iswrite = settings(file_desc, shared)
iswrite && grow && grow!(io, offset, len)
!iswrite && mmaplen > filesize(io) && throw(ArgumentError("unable to mmap file size smaller than $mmaplen due to read-only permissions. Please check your dims"))
xgdgsc marked this conversation as resolved.
Show resolved Hide resolved
# mmap the file
ptr = ccall(:jl_mmap, Ptr{Cvoid}, (Ptr{Cvoid}, Csize_t, Cint, Cint, RawFD, Int64),
C_NULL, mmaplen, prot, flags, file_desc, offset_page)
Expand Down