Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 fix bus error on smaller readonly file in unix #44354

Merged
merged 10 commits into from
Aug 21, 2023
Merged

馃悰 fix bus error on smaller readonly file in unix #44354

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c9e56d4
馃悰 fix bus error on smaller readonly file in unix
xgdgsc Feb 26, 2022
10588f3
Update stdlib/Mmap/src/Mmap.jl
xgdgsc Feb 26, 2022
de9c375
Update stdlib/Mmap/src/Mmap.jl
xgdgsc Mar 1, 2022
b8bb51b
logic cleanup
xgdgsc Mar 1, 2022
b7829c9
Apply suggestions from code review
vtjnash Nov 8, 2022
015812f
馃悰 try fix ci fail
xgdgsc Jan 12, 2023
bc0cdaa
Update stdlib/Mmap/src/Mmap.jl
xgdgsc Jan 13, 2023
8b02ca4
try skip for 馃崕
xgdgsc Jul 15, 2023
67bab23
try keep old behaviror for 馃崕
xgdgsc Jul 15, 2023
fe71de3
Merge branch 'master' into xgdgsc-patch-1
xgdgsc Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@vtjnash
vtjnash committed Jul 18, 2023
commit b7829c9fe0d5b24e1891d93eb9141243983aaaf7
6 changes: 2 additions & 4 deletions stdlib/Mmap/src/Mmap.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,7 @@ function mmap(io::IO,
else
throw(ArgumentError("requested size $szfile larger than file size $(filesize(io)), but requested not to grow"))
end
end
if !iswrite
else
throw(ArgumentError("unable to increase file size to $szfile due to read-only permissions"))
end
end
Expand All @@ -234,8 +233,7 @@ function mmap(io::IO,
if requestedSizeLarger
if readonly
throw(ArgumentError("unable to increase file size to $szfile due to read-only permissions"))
end
if !readonly && !grow
elseif !grow
throw(ArgumentError("requested size $szfile larger than file size $(filesize(io)), but requested not to grow"))
end
end
Expand Down