Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Distributed] Return value obtained from call_on_owner directly #43398

Merged
merged 1 commit into from
Dec 11, 2021
Merged

[Distributed] Return value obtained from call_on_owner directly #43398

merged 1 commit into from
Dec 11, 2021

Conversation

krynju
Copy link
Contributor

@krynju krynju commented Dec 11, 2021

Fixes #43396
Caused by this: #42339

v_local stores the value obtained through call_on_owner.

I forgot this value is not wrapped in Some and the code was attemptingto unwrap it with something at the end of the function.

Worked well for non-nothing values, but when fetch was actually returning a nothing value then an error was thrown due to something(nothing) being illegal

2nd test case is not related to the issue, but added it for safety in case there's any further work done on this part of code

Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superficially LGTM! Thanks for the amazingly rapid fix @krynju! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants