Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PkgEval failures after merging #42339 ([Distributed] Worker local race condition between put! and fetch for Futures) #43396

Closed
KristofferC opened this issue Dec 11, 2021 · 3 comments · Fixed by #43398
Milestone

Comments

@KristofferC
Copy link
Sponsor Member

Putting this on the 1.8 milestone so it is not forgotten.

#42339 (comment)

@KristofferC KristofferC added this to the 1.8 milestone Dec 11, 2021
@krynju
Copy link
Contributor

krynju commented Dec 11, 2021

Seems like some issue with unwrapping nothing values specifically.
I'll try to investigate/fix it this weekend

Here's an MWE:

julia> using Distributed

julia> addprocs(1)
1-element Vector{Int64}:
 2

julia> fetch(remotecall(() -> 10, 2))
10

julia> fetch(remotecall(() -> nothing, 2))
ERROR: ArgumentError: No value arguments present
Stacktrace:
 [1] something()
   @ Base .\some.jl:99   
 [2] something(::Nothing)
   @ Base .\some.jl:100  
 [3] fetch(r::Future)    
   @ Distributed C:\cygwin64\home\krynjupc\julia\usr\share\julia\stdlib\v1.8\Distributed\src\remotecall.jl:638
 [4] top-level scope
   @ REPL[3]:1

@krynju
Copy link
Contributor

krynju commented Dec 11, 2021

Ok this was actually a simple one. I overlooked the return logic in fetch and was attempting to do something(nothing) at some point in code

Here's the PR #43398

@Sacha0
Copy link
Member

Sacha0 commented Dec 11, 2021

Thanks Krystian! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants