Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isaccessiblefile for isfile_casesensitive #42922

Merged
merged 5 commits into from
Jan 12, 2022
Merged

Use isaccessiblefile for isfile_casesensitive #42922

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4d622b1
Add `safe_isfile`, `safe_isdir`, `safe_ispath` and tests
ven-k Nov 5, 2021
b8df05b
`safe_is` -> `isaccessible`
ven-k Nov 10, 2021
08e5c3c
the issue is not observed on Windows. So continue using isfile
ven-k Dec 14, 2021
3bb4ebe
Merge branch 'master' into vk/safe_isfile
ven-k Dec 14, 2021
b08f8e7
Check if file is accessible on windows too
ven-k Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
the issue is not observed on Windows. So continue using isfile
  • Loading branch information
@ven-k
ven-k committed Dec 14, 2021
commit 08e5c3cd8bd41f7afabd143d8caf63ab0e570e00
2 changes: 1 addition & 1 deletion base/loading.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ if Sys.isunix() && !Sys.isapple()
elseif Sys.iswindows()
# GetLongPathName Win32 function returns the case-preserved filename on NTFS.
function isfile_casesensitive(path)
isaccessiblefile(path) || return false # Fail fast
isfile(path) || return false # Fail fast
basename(Filesystem.longpath(path)) == basename(path)
end
elseif Sys.isapple()
Expand Down