Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isaccessiblefile for isfile_casesensitive #42922

Merged
merged 5 commits into from
Jan 12, 2022
Merged

Use isaccessiblefile for isfile_casesensitive #42922

merged 5 commits into from
Jan 12, 2022

Conversation

ven-k
Copy link
Member

@ven-k ven-k commented Nov 3, 2021

Addresses issue #42876

  • The safe_isfile returns false when stat fails on the path
  • Among many bugs it solves the issue with creating scratchspaces on relocated sysimage

@KristofferC while here, should I also add safe_ispath and safe_isdir ?

ven-k
ven-k commented Nov 3, 2021
View reviewed changes
base/loading.jl Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Nov 3, 2021
View reviewed changes
base/loading.jl Outdated Show resolved Hide resolved
@DilumAluthge
Copy link
Member

Can you rebase on the latest master? That will fix the httpbingo failures.

@ven-k ven-k requested a review from a team as a code owner November 5, 2021 10:57
@DilumAluthge
Copy link
Member

Something's gone wrong with your rebase - there are a bunch of unrelated commits on the branch.

@ven-k
Copy link
Member Author

ven-k commented Nov 5, 2021

I'll close this and open a fresh one. Sorry for the noise

@ven-k ven-k closed this Nov 5, 2021
@KristofferC
Copy link
Sponsor Member

You can just force push to this PR. There is no need to open new PRs.

@ven-k ven-k reopened this Nov 5, 2021
@DilumAluthge DilumAluthge removed the request for review from a team November 5, 2021 12:02
@ven-k ven-k changed the title Use safe_isfile for isfile_casesensitive Use isaccessiblefile for isfile_casesensitive Dec 14, 2021
@ven-k ven-k requested a review from vtjnash December 14, 2021 17:28
@ven-k
Copy link
Member Author

ven-k commented Dec 20, 2021

@vtjnash I've changed the function name to isaccessiblefile. Is there any additional thing to add (or rm)

@vtjnash vtjnash merged commit 0279b73 into JuliaLang:master Jan 12, 2022
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jan 12, 2022

We may want to consider exporting these from Base.Filesystem, document them, and use them in other places (such as REPLCompletions) now

LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@ven-k @LilithHafner
Add and use isaccessiblefile for isfile_casesensitive (JuliaLang#…
9ff9679 
…42922)

Fixes JuliaLang#42876
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@ven-k @LilithHafner
Add and use isaccessiblefile for isfile_casesensitive (JuliaLang#…
118a413 
…42922)

Fixes JuliaLang#42876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj left review comments

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ven-k @DilumAluthge @KristofferC @vtjnash @stevengj