Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make compact type alias output more compact #39256

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Conversation

JeffBezanson
Copy link
Sponsor Member

I just noticed that the "compact" output for type aliases is currently much less compact:

julia> show(IOContext(stdout,:compact=>false), MIME"text/plain"(), Matrix)
Array{T, 2} where T

julia> show(IOContext(stdout,:compact=>true), MIME"text/plain"(), Matrix)
Matrix{T} where T (alias for Array{T, 2} where T)

after:

julia> show(IOContext(stdout,:compact=>false), MIME"text/plain"(), Matrix)
Matrix{T} where T (alias for Array{T, 2} where T)

julia> show(IOContext(stdout,:compact=>true), MIME"text/plain"(), Matrix)
Matrix{T} where T

This is new functionality in 1.6 so I would consider backporting this frankly.

@JeffBezanson JeffBezanson added domain:display and printing Aesthetics and correctness of printed representations of objects. status:triage This should be discussed on a triage call labels Jan 14, 2021
base/show.jl Show resolved Hide resolved
@JeffBezanson JeffBezanson added needs pkgeval Tests for all registered packages should be run with this change backport 1.6 Change should be backported to release-1.6 and removed status:triage This should be discussed on a triage call labels Jan 21, 2021
base/show.jl Outdated Show resolved Hide resolved
@KristofferC KristofferC mentioned this pull request Jan 26, 2021
60 tasks
@KristofferC KristofferC removed the needs pkgeval Tests for all registered packages should be run with this change label Jan 28, 2021
@KristofferC
Copy link
Sponsor Member

I don't think this needs a PkgEval really since we haven't released an RC yet.

@KristofferC KristofferC merged commit c8cc69b into master Jan 29, 2021
@KristofferC KristofferC deleted the jb/compacttypealias branch January 29, 2021 07:37
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Feb 1, 2021
@ericphanson
Copy link
Contributor

it seems like this didn't get backported to 1.6; any chance for it to be in 1.6.1?

julia> VERSION
v"1.6.0"

julia> show(IOContext(stdout,:compact=>false), MIME"text/plain"(), Matrix)
Array{T, 2} where T
julia> show(IOContext(stdout,:compact=>true), MIME"text/plain"(), Matrix)
Matrix{T} where T (alias for Array{T, 2} where T)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:display and printing Aesthetics and correctness of printed representations of objects.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants