add shorter show method for AbstractColumns
#236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
This table used to print as 1.2M characters! (The “alias” printing is removed with JuliaLang/julia#39256 I believe).
I tried to be pretty safe here since
AbstractColumns
are very general, and I'm not sure if we can expect columns to have alength
for example.I decided to print the schema instead of a manual column printing as in apache/arrow-julia#168, since we don't have the
eltype
info in general (columntypes
just asks the schema, so the fallback method only works when we have a schema), and I think maybe if Tables doesn't have a schema that can be useful info to pass along to the user (perhaps they can add one and improve performance in some cases).