Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from NSIS to Inno Setup installer #33375

Merged
merged 1 commit into from
Sep 28, 2019
Merged

Conversation

musm
Copy link
Contributor

@musm musm commented Sep 24, 2019

While working on trying to remove the extra 7z stage we do on the NSIS installer, I realized this was not ideal since NSIS only implements lzma and not more recent compression methods from 7z.

Instead, I opted to transition to Inno setup, it's actually far easier to use and more robust and modern than NSIS. This also compress the files with lzma2

refixes #30475

@ViralBShah ViralBShah added system:windows Affects only Windows domain:building Build system, or building Julia or its dependencies labels Sep 24, 2019
@musm
Copy link
Contributor Author

musm commented Sep 24, 2019

Installer experience

NEW
t2

OLD
t1

@musm
Copy link
Contributor Author

musm commented Sep 27, 2019

This is ready on my end

@staticfloat
Copy link
Sponsor Member

This looks really good to me, @musm. Thanks for the solid effort here, and especially for the "installation experience" GIF. Just to be doubly sure that CI and whatnot works well on this branch, I'm going to merge your CI PR, wait for this to make its way through CI, then download and install on a windows machine to ensure that everything is as beautiful as it looks.

@staticfloat
Copy link
Sponsor Member

Works flawlessly. Merging.

@staticfloat
Copy link
Sponsor Member

Actually, one more thing; let's add a NEWS.md entry about this to tell users that CLI extraction should use the new slash flags, to avoid frustration. :)

We also may have to update Appveyor.jl and Travis.

@musm
Copy link
Contributor Author

musm commented Sep 28, 2019

Done

My my own reference: The following can be used on the svg from julia-branding to generate the bmp files used in the installer.

> magick convert banner.svg -transparent white -background white -flatten -resize 164x -gravity center -extent 164x314 -density 1000 julia-banner.bmp

@staticfloat staticfloat merged commit 4849593 into JuliaLang:master Sep 28, 2019
@staticfloat
Copy link
Sponsor Member

Good work @musm!

@musm
Copy link
Contributor Author

musm commented Sep 28, 2019

Great thanks for the merge. I'm glad of the resulting simplicity of the new builder.

@musm musm deleted the inno branch September 28, 2019 21:08
@fredrikekre
Copy link
Member

We also may have to update Appveyor.jl and Travis.

Looks like this is the case. At least AV is broken now.

@musm
Copy link
Contributor Author

musm commented Sep 29, 2019

JuliaCI/Appveyor.jl#19

@musm
Copy link
Contributor Author

musm commented Sep 30, 2019

Appveyor is fixed.

Could someone with more experience in Travis implement the fix there?
Something like musm/travis-build#1 is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:building Build system, or building Julia or its dependencies system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants