Update from NSIS to Inno Setup installer #33375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on trying to remove the extra 7z stage we do on the NSIS installer, I realized this was not ideal since NSIS only implements lzma and not more recent compression methods from 7z.
Instead, I opted to transition to Inno setup, it's actually far easier to use and more robust and modern than NSIS. This also compress the files with lzma2
refixes #30475