Julia installer for Windows contains out-of-date properties #25677
Labels
system:windows
Affects only Windows
Comments
|
I think it's from this file: https://github.com/JuliaLang/julia/commits/master/contrib/windows/7zS.sfx |
|
Is this even worth fixing? cc @ihnorton |
|
Seems like we should either fix or not ship (if not required). |
|
The only way to change this string is to edit the resource table of the sfx
file Jameson linked. I did a quick google and didn't find a command line
utility to do this on linux, so I'm inclined to just change the string to
"See filename" for now... Unless someone has time to add resource table
support to COFF.jl, including in particular [StringFileInfo](
https://msdn.microsoft.com/en-us/library/windows/desktop/aa381049(v=vs.85).aspx),
and teach the build system how to use it.
…On Mon, Jan 22, 2018 at 2:15 AM, Viral B. Shah ***@***.***> wrote:
Seems like we should either fix or not ship (if not required).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25677 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUAGqtI5uLw4vxkTxzrqekkhm2WaHggks5tNDWYgaJpZM4Rl9b3>
.
|
|
Well here's one that has command line support and could be run under wine:
http:https://www.angusj.com/resourcehacker/
Not inclined to do that, though, because it seems like another brittle
step. If anyone knows of a linux-native alternative, let me know.
On Mon, Jan 22, 2018 at 10:21 AM, Isaiah Norton <[email protected]>
wrote:
… The only way to change this string is to edit the resource table of the
sfx file Jameson linked. I did a quick google and didn't find a command
line utility to do this on linux, so I'm inclined to just change the string
to "See filename" for now... Unless someone has time to add resource table
support to COFF.jl, including in particular [StringFileInfo](https://msdn.
microsoft.com/en-us/library/windows/desktop/aa381049(v=vs.85).aspx), and
teach the build system how to use it.
On Mon, Jan 22, 2018 at 2:15 AM, Viral B. Shah ***@***.***>
wrote:
> Seems like we should either fix or not ship (if not required).
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#25677 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAUAGqtI5uLw4vxkTxzrqekkhm2WaHggks5tNDWYgaJpZM4Rl9b3>
> .
>
|
|
We could probably change this once, to "Installer v1.0 for Julia", and then leave it alone. |
|
I agree, there's no reason the installer needs to have the same version as Julia. |
|
shouldn't windres be able to modify these? |
|
@musm do you know the status for this? |
|
It's no longer outdated, I just checked the properties of And for nightly it's slightly different: |
|
yep now fixed |
|
right, the installer was replaced (by musm) in #33375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Julia installer for Windows contains out-of-date properties. The version displays
0.3-preand the copyright is a few years behind. Affects the installers for both 0.6.2 and nightlies. I grepped the repo and was unable to find the source of these values.The text was updated successfully, but these errors were encountered: