Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update julia.appdata.xml to a new AppStream specification. #28020

Merged
merged 2 commits into from
Aug 15, 2018
Merged

Update julia.appdata.xml to a new AppStream specification. #28020

merged 2 commits into from
Aug 15, 2018

Conversation

cdluminate
Copy link
Contributor

closes: #27996

@cdluminate cdluminate mentioned this pull request Jul 10, 2018
Closed
@ViralBShah
Copy link
Member

cc @nalimilan

nalimilan
nalimilan approved these changes Jul 10, 2018
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! While we're at it, I've added a <provides/> tag. The file passes validation tests locally.

EDIT: cancelling CI since it doesn't check that file at all.

@kshyatt
Copy link
Contributor

kshyatt commented Aug 3, 2018

Whoa CI failures. Should we re-run this? Or can it be merged as-is?

@nalimilan
Copy link
Member

Yes, CI doesn't really check that file anyway. If it's OK to merge PRs at the moment, please do so.

@nalimilan nalimilan merged commit 48a9ec4 into JuliaLang:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

julia.appdata.xml uses an ancient version of the AppStream specification
4 participants
@cdluminate @ViralBShah @kshyatt @nalimilan