Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

julia.appdata.xml uses an ancient version of the AppStream specification #27996

Closed
cdluminate opened this issue Jul 9, 2018 · 2 comments · Fixed by #28020
Closed

julia.appdata.xml uses an ancient version of the AppStream specification #27996

cdluminate opened this issue Jul 9, 2018 · 2 comments · Fixed by #28020

Comments

@cdluminate
Copy link
Contributor

$ appstreamcli validate contrib/julia.appdata.xml 
E - julia.appdata.xml:~:3
    The metainfo file uses an ancient version of the AppStream specification, which 
    can not be validated. Please migrate it to version 0.6 (or higher).

Validation failed: errors: 1

The following patch is taken from Debian's package. It makes Debian's package checker happy, but I'm not sure whether it's correct.

Purpose: lintian error due to ancient version of metadata format
Reference: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html
Created-by: Mo Zhou
Last-Update: 2018-07-04
Forwarded: not yet.

diff --git a/contrib/julia.appdata.xml b/contrib/julia.appdata.xml
index 576d883..e88a844 100644
--- a/contrib/julia.appdata.xml
+++ b/contrib/julia.appdata.xml
@@ -1,9 +1,11 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!-- Copyright 2014 Paul Lange <[email protected]> -->
-<application>
- <id type="desktop">julia.desktop</id>
+<component>
+ <id>org.julialang.www</id>
+ <name>Julia</name>
  <metadata_license>CC-BY-SA-3.0</metadata_license>
  <project_license>MIT and LGPL-2.1+ and GPL-2.0+</project_license>
+ <summary>high-performance programming language for technical computing</summary>
  <description>
   <p>
    Julia is a high-level, high-performance dynamic programming language for
@@ -20,9 +22,6 @@
    external packages through Julia’s built-in package manager at a rapid pace.
   </p>
  </description>
- <screenshots>
-  <screenshot type="default">https://julialang.org/images/julia-gnome.png</screenshot>
- </screenshots>
  <url type="homepage">https://julialang.org/</url>
- <updatecontact>[email protected]</updatecontact>
-</application>
+ <update_contact>[email protected]</update_contact>
+</component>
@nalimilan
Copy link
Member

Thanks. Would you open a pull request?

A few remarks:

  • org.julialang.www should be org.julialang.julia
  • the .desktop file should be moved to a ⁠<launchable> section
  • the screenshorts should be kept (and we should update it, but it can be done at any time)
  • I think there should be an upper case to "High-performance"
  • finally, I think you can remove the update contact, as the address is no longer valid and there's no replacement (Discourse isn't an e-mail address).

@cdluminate
Copy link
Contributor Author

@nalimilan Thanks for the comment. See #28020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants