Remove the examples/ folder #26153
Merged
Remove the examples/ folder #26153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe re-add the example removed in #25606, it could be of historical interest... |
staticfloat
requested changes
Feb 24, 2018
doc/src/manual/parallel-computing.md
Outdated
| @@ -1246,7 +1247,7 @@ transport and Julia's in-built parallel infrastructure. | |||
| A `BufferStream` is an in-memory [`IOBuffer`](@ref) which behaves like an `IO`--it is a stream which can | |||
| be handled asynchronously. | |||
|
|
|||
| Folder `examples/clustermanager/0mq` contains an example of using ZeroMQ to connect Julia workers | |||
| The folder `clustermanager/0mq` in the Examples repository contains an example of using ZeroMQ to connect Julia workers | |||
There was a problem hiding this comment.
It might be nice to actually link to the Examples repository here
| @@ -258,7 +258,7 @@ julia> subtypes(Integer) | |||
| subtypes(x::Type) = _subtypes_in(Base.loaded_modules_array(), x) | |||
|
|
|||
| # dumptype is for displaying abstract type hierarchies, | |||
| # based on Jameson Nash's examples/typetree.jl | |||
| # based on Jameson Nash's typetree.jl in JuliaArchive/Examples | |||
There was a problem hiding this comment.
... in the GitHub repository JuliaArchive/Examples. Otherwise I might think this is a folder within this repository.
ararslan
force-pushed
the
aa/no-more-examples
branch
from
2580d15
to
53ed1ab
Compare
staticfloat
reviewed
Feb 27, 2018
contrib/windows/appveyor_build.sh
Outdated
| @@ -207,6 +207,6 @@ echo 'FORCE_ASSERTIONS = 1' >> Make.user | |||
| cat Make.user | |||
| make -j3 VERBOSE=1 all | |||
| make -j3 VERBOSE=1 install | |||
| make VERBOSE=1 -C examples | |||
| make VERBOSE=1 -C test/embedding release | |||
There was a problem hiding this comment.
Try this instead:
make VERBOSE=1 JULIA=usr/bin/julia.exe BIN=test/embedding -C test/embedding release
There was a problem hiding this comment.
make: Entering directory '/cygdrive/c/projects/julia/test/embedding'
make: usr/bin/julia.exe: Command not found
make: usr/bin/julia.exe: Command not found
cc /cygdrive/c/projects/julia/test/embedding/embedding.c -o test/embedding/embedding.exe -lm
make: cc: Command not found
make: *** [Makefile:36: test/embedding/embedding.exe] Error 127
make: Leaving directory '/cygdrive/c/projects/julia/test/embedding'
There was a problem hiding this comment.
This makefile isn't intended to be called directly from inside the Julia tree. That's why embedding/Makefile existed to read in the configuration variables from Make.inc and forward them to the example.
There was a problem hiding this comment.
Okay. We just need to find a way to compile the embedding test's C code while building Julia so that a compiler isn't needed to run the embedding test. (Unless that's okay.)
ararslan
force-pushed
the
aa/no-more-examples
branch
3 times, most recently
from
5f8ff73
to
5ae9eff
Compare
ararslan
force-pushed
the
aa/no-more-examples
branch
from
5ae9eff
to
1ec6cd9
Compare
|
32-bit Windows failure is #26280 |
|
@staticfloat Does this look okay now? |
mbauman
added a commit
that referenced
this pull request
Mar 5, 2018
…luenonscalarindexedassignment * origin/master: (28 commits) fix an optimizer bug in `invoke` with non-constant functions (#26301) lower top-level statements in such a way that the front-end knows (#26304) Make sure Sockets page has h1 header (#26315) fix doctests, and make them less prone to errors (#26275) FIx intro to manual chapter on types (#26312) Add a missing "that" (#26313) fix docstring for code_llvm (#26266) Remove the examples/ folder (#26153) download cert.pem from deps-getall, fixes #24903 (#25344) Slight update to doc string for at-enum to refer to instances (#26208) performance tweak in reverse(::String) (#26300) remove references to `TCPSocket` in Base docstrings (#26298) Deprecate adding integers to CartesianIndex (#26284) Deprecate conj(::Any), add real(::Missing) and imag(::Missing) (#26288) fix #26267, regression in `names` with `imported=false` (#26293) fix #25857, `typeinfo` problem in showing arrays with abstract tuple types (#26289) Add adjoint(::Missing) method (#25502) Use lowered form in logging macro (#26291) deprecate bin, oct, dec, hex, and base in favor of `string` and keyword args (#25804) deprecate `spawn(cmd)` to `run(cmd, wait=false)` (#26130) ...
vtjnash
added a commit
that referenced
this pull request
Jun 11, 2018
vtjnash
added a commit
that referenced
this pull request
Jun 12, 2018
vtjnash
added a commit
that referenced
this pull request
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been moved to https://github.com/JuliaArchive/Examples.