Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download cert.pem from deps-getall, fixes #24903 #25344

Merged
merged 1 commit into from
Mar 3, 2018

Conversation

JaredCrean2
Copy link
Contributor

Fixes #24903.

It would be good to create a test for this, but I'm not sure the best way to do it. Do the CI tests build julia from scratch every time, or are some dependencies cached?

@ararslan
Copy link
Member

ararslan commented Jan 1, 2018

Do the CI tests build julia from scratch every time, or are some dependencies cached?

All dependencies are cached using CCache, otherwise just building Julia, not even running the tests, would likely more than exceed the time limit for CI services.

@JaredCrean2
Copy link
Contributor Author

Are there any facilities for running tests less frequently, perhaps weekly?

@ararslan
Copy link
Member

ararslan commented Jan 1, 2018

Not really. A test wouldn't hurt either way though.

@JaredCrean2
Copy link
Contributor Author

JaredCrean2 commented Jan 1, 2018

I'm not sure how to write it. A standalone shell script?

Edit: I should be more descriptive. The property that I really want to test is that make succeeds even after make -C deps getall without internet access. I could write a little shell script to do this, but it would probably be linux only. I'm also not sure where the shell script would live in the repo.

@ararslan
Copy link
Member

ararslan commented Jan 1, 2018

Oh, hm, I'm not sure. I'll wait for someone else to chime in here.

@ararslan ararslan added external dependencies Involves LLVM, OpenBLAS, or other linked libraries libgit2 The libgit2 library or the LibGit2 stdlib module labels Jan 2, 2018
@JaredCrean2
Copy link
Contributor Author

Bump. This PR is a strict improvement over the current state, so I'd like to get this merged soon. Testing different build configurations is important, but a much larger issue.

@StefanKarpinski
Copy link
Sponsor Member

@staticfloat, does this look good to you? If so, we should merge.

@staticfloat staticfloat merged commit 4350098 into JuliaLang:master Mar 3, 2018
mbauman added a commit that referenced this pull request Mar 5, 2018
…luenonscalarindexedassignment

* origin/master: (28 commits)
  fix an optimizer bug in `invoke` with non-constant functions (#26301)
  lower top-level statements in such a way that the front-end knows (#26304)
  Make sure Sockets page has h1 header (#26315)
  fix doctests, and make them less prone to errors (#26275)
  FIx intro to manual chapter on types (#26312)
  Add a missing "that" (#26313)
  fix docstring for code_llvm (#26266)
  Remove the examples/ folder (#26153)
  download cert.pem from deps-getall, fixes #24903 (#25344)
  Slight update to doc string for at-enum to refer to instances (#26208)
  performance tweak in reverse(::String) (#26300)
  remove references to `TCPSocket` in Base docstrings (#26298)
  Deprecate adding integers to CartesianIndex (#26284)
  Deprecate conj(::Any), add real(::Missing) and imag(::Missing) (#26288)
  fix #26267, regression in `names` with `imported=false` (#26293)
  fix #25857, `typeinfo` problem in showing arrays with abstract tuple types (#26289)
  Add adjoint(::Missing) method (#25502)
  Use lowered form in logging macro (#26291)
  deprecate bin, oct, dec, hex, and base in favor of `string` and keyword args (#25804)
  deprecate `spawn(cmd)` to `run(cmd, wait=false)` (#26130)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries libgit2 The libgit2 library or the LibGit2 stdlib module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants