Add infrastructure for testing julia's LLVM passes #21498
Next
Next commit
Add infrastructure for testing julia's LLVM passes
- Loading branch information
commit cae6ca798c793a1550c39eee83a8f7785a3e836c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| ifeq ($(LLVM_DEBUG),1) | ||
| LLVM_BUILDTYPE := Debug | ||
| else | ||
| LLVM_BUILDTYPE := Release | ||
| endif | ||
| LLVM_CMAKE_BUILDTYPE := $(LLVM_BUILDTYPE) | ||
| ifeq ($(LLVM_ASSERTIONS),1) | ||
| LLVM_BUILDTYPE := $(LLVM_BUILDTYPE)+Asserts | ||
| endif | ||
| LLVM_FLAVOR := $(LLVM_BUILDTYPE) | ||
| ifeq ($(LLVM_SANITIZE),1) | ||
| ifeq ($(SANITIZE_MEMORY),1) | ||
| LLVM_BUILDTYPE := $(LLVM_BUILDTYPE)+MSAN | ||
| else | ||
| LLVM_BUILDTYPE := $(LLVM_BUILDTYPE)+ASAN | ||
| endif | ||
| endif | ||
|
|
||
| LLVM_SRC_DIR:=$(SRCDIR)/srccache/llvm-$(LLVM_VER) | ||
| LLVM_BUILD_DIR:=$(BUILDDIR)/llvm-$(LLVM_VER) | ||
| LLVM_BUILDDIR_withtype := $(LLVM_BUILD_DIR)/build_$(LLVM_BUILDTYPE) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| SRCDIR := $(abspath $(dir $(lastword $(MAKEFILE_LIST)))) | ||
| JULIAHOME := $(abspath $(SRCDIR)/../..) | ||
| include $(JULIAHOME)/deps/Versions.make | ||
| include $(JULIAHOME)/Make.inc | ||
| include $(JULIAHOME)/deps/llvm-ver.make | ||
| BUILDDIR = $(JULIAHOME)/deps/scratch | ||
| include $(JULIAHOME)/deps/llvm-options.mk | ||
| LLVM_SRC_DIR:=$(JULIAHOME)/deps/srccache/llvm-$(LLVM_VER) | ||
|
There was a problem hiding this comment. These configuration options aren't really right, since they assume a very specific in-tree source build layout. Does LLVM not provide any way to run its test framework out-of-tree? There was a problem hiding this comment. You can build it out of tree, but you need a copy of lit which is in the LLVM source dir. You can probably make it work, but might be easier for somebody who uses out-of-tree builds to fix this up after committing this. |
||
| test: | ||
| PATH=$$PATH:$(LLVM_BUILDDIR_withtype)/bin $(LLVM_SRC_DIR)/utils/lit/lit.py -v . | ||
| .PHONY: test | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import os | ||
| import sys | ||
| import re | ||
| import platform | ||
|
|
||
| import lit.util | ||
| import lit.formats | ||
|
|
||
| config.name = 'Julia' | ||
| config.suffixes = ['.ll'] | ||
| config.test_source_root = os.path.dirname(__file__) | ||
| config.test_format = lit.formats.ShTest(False) | ||
|
|
||
| path = os.path.pathsep.join((os.path.join(os.path.dirname(__file__),"../../usr/tools"), config.environment['PATH'])) | ||
| config.environment['PATH'] = path |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to be conditional on llvm version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like 3.8 was the first version with this option. However, I don't think CMake complains too loudly if you pass it an option it doesn't recognize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.8 is the first version that we actually use CMAKE on so it should not be a problem, see #19054.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Keno this flag caused #21621 - why was this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you can load libjulia into opt and use the llvm passes.