Add infrastructure for testing julia's LLVM passes #21498
Conversation
| @@ -124,7 +104,7 @@ ifeq ($(USE_LLVM_SHLIB),1) | |||
| # NOTE: we could also --disable-static here (on the condition we link tools | |||
| # against libLLVM) but there doesn't seem to be a CMake counterpart option | |||
| LLVM_FLAGS += --enable-shared | |||
| LLVM_CMAKE += -DLLVM_BUILD_LLVM_DYLIB:BOOL=ON | |||
| LLVM_CMAKE += -DLLVM_BUILD_LLVM_DYLIB:BOOL=ON -DLLVM_LINK_LLVM_DYLIB:BOOL=ON | |||
There was a problem hiding this comment.
does this need to be conditional on llvm version?
There was a problem hiding this comment.
Looks like 3.8 was the first version with this option. However, I don't think CMake complains too loudly if you pass it an option it doesn't recognize.
There was a problem hiding this comment.
3.8 is the first version that we actually use CMAKE on so it should not be a problem, see #19054.
There was a problem hiding this comment.
so you can load libjulia into opt and use the llvm passes.
| include $(JULIAHOME)/deps/llvm-ver.make | ||
| BUILDDIR = $(JULIAHOME)/deps/scratch | ||
| include $(JULIAHOME)/deps/llvm-options.mk | ||
| LLVM_SRC_DIR:=$(JULIAHOME)/deps/srccache/llvm-$(LLVM_VER) |
There was a problem hiding this comment.
These configuration options aren't really right, since they assume a very specific in-tree source build layout. Does LLVM not provide any way to run its test framework out-of-tree?
There was a problem hiding this comment.
You can build it out of tree, but you need a copy of lit which is in the LLVM source dir. You can probably make it work, but might be easier for somebody who uses out-of-tree builds to fix this up after committing this.
Infrastructure pieces split out from #21158