Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat of README.windows.md #21285

Merged
merged 3 commits into from
Apr 6, 2017

Conversation

m-j-w
Copy link
Contributor

@m-j-w m-j-w commented Apr 5, 2017

Same as the README.md before, the README.windows.md also renders incorrectly on Github.
Thus, reformatted it for the various lists to count and indent correctly, and made only very minor editorial changes (marked a link as dead, corrected pacman update command).

@tkelman
Copy link
Contributor

tkelman commented Apr 5, 2017

We should remove the msys2 instructions. They don't currently work. Can be put back later, less recommended than cygwin cross compile, if someone gets it working again.

Reformatted to make it render correctly on Github.
Only minor editorial changes (marked link as dead, corrected pacman update command).

(and whitespace error hopefully corrected...)
@m-j-w
Copy link
Contributor Author

m-j-w commented Apr 5, 2017

I would rather not make that change myself since I'm basically exclusively on Linux nowadays.
Also, I still fail to get a proper build on Windows, which is why being able to read it was my main concern...
But please feel free to cherry-pick.


# Binary distribution
Instructions for adding fonts to the terminal are available at
[Microsoft KB-247815 (dead link)](
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably avoid dead links. Maybe https://superuser.com/a/5079 would be a good choice.

https://code.google.com/p/mintty/) (note that running Julia on Mintty needs a
copy of `stty.exe` in your `%PATH%` to work properly). Alternatively, you may
prefer the features of a more full-function IDE, such as [Juno](http:https://junolab.org),
[LightTable](https://github.com/one-more-minute/Jupiter-LT),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jupiter-LT appears no longer to exist.

- Windows 7: supported (32 and 64 bits)
- Windows Vista: not officially supported (but probably works anyways)
- Windows XP: not supported (but may work anyways, if you can get around the
lack of junction points)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mention XP or Vista

@ararslan ararslan added domain:docs This change adds or pertains to documentation system:MS-DOS See the Windows label system:windows Affects only Windows labels Apr 5, 2017
@ararslan
Copy link
Member

ararslan commented Apr 5, 2017

As an aside, you can add [ci skip] to commit messages for commits that only touch READMEs. That avoids rerunning the entire hour-long build and test.


**On Both:**
Unfortunately, the version of gcc installed by Ubuntu targets pthreads. On Mac,
the situation is similar: the version in MacPorts is very old and Homebrew does
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These statements (and the rest of the section) are false now. Macports and Homebrew have mingw-w64 now, and our build now requires the pthreads thread model instead of win32.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also who uses MacPorts anymore 😛

@StefanKarpinski
Copy link
Sponsor Member

Correctness of instructions is orthogonal to reformatting. Does anyone have any issues with the reformatting itself?

2. From the *Net* category: `curl`
3. From *Interpreters* (or *Python*) category: `m4`, `python`
4. From the *Archive* category: `p7zip`
5. For 32 bit Julia, only, and also from the *Devel* category:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop the "only" here

@m-j-w
Copy link
Contributor Author

m-j-w commented Apr 6, 2017

Done, and this time with [ci skip].

@StefanKarpinski StefanKarpinski merged commit 7421e11 into JuliaLang:master Apr 6, 2017
@StefanKarpinski
Copy link
Sponsor Member

StefanKarpinski commented Apr 6, 2017

@tkelman, @vtjnash: please open issues for the correctness issues of this documentation. Or better still just make PRs fixing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation system:MS-DOS See the Windows label system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants