Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address concerns that depwarn for transpose is unclear #19205

Merged
merged 4 commits into from
Nov 5, 2016
Merged

address concerns that depwarn for transpose is unclear #19205

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a5fecbc
address https://github.com/JuliaLang/julia/issues/18320
cjprybol Nov 3, 2016
0378921
Update NEWS.md
cjprybol Nov 3, 2016
cbc7aa3
Update deprecated.jl
cjprybol Nov 3, 2016
176bd85
Update deprecated.jl
cjprybol Nov 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update deprecated.jl
  • Loading branch information
@cjprybol
cjprybol committed Nov 3, 2016
commit cbc7aa359cd907e16e63c2d75d8a95af744a5e95
3 changes: 2 additions & 1 deletion base/deprecated.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,8 @@ end
function transpose(x)
depwarn(string("the no-op `transpose` for non-numeric arrays is deprecated, ",
"and no specific `transpose` method for $(typeof(x)) exists. Use ",
"permutedims(x, (2, 1)) for matrices and reshape(x, 1, length(x)) for vectors."),
"permutedims(x, (2, 1)) for matrices and reshape(x, 1, length(x)) for vectors, ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should preserve the backticks around permutedims(...) and reshape(...).

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye, thanks!

"or write a specific `transpose(x::$(typeof(x)))` method if appropriate."),
:transpose)
return x
end
Expand Down