address concerns that depwarn for transpose is unclear #19205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjprybol
changed the title
tkelman
approved these changes
Nov 4, 2016
|
LGTM |
ararslan
requested changes
Nov 4, 2016
| "or writing a specific `transpose(x::$(typeof(x)))` method if appropriate."), | ||
| depwarn(string("the no-op `transpose` for non-numeric arrays is deprecated, ", | ||
| "and no specific `transpose` method for $(typeof(x)) exists. Use ", | ||
| "permutedims(x, (2, 1)) for matrices and reshape(x, 1, length(x)) for vectors, ", |
There was a problem hiding this comment.
Should preserve the backticks around permutedims(...) and reshape(...).
There was a problem hiding this comment.
Good eye, thanks!
tkelman
pushed a commit
that referenced
this pull request
Feb 22, 2017
fcard
pushed a commit
to fcard/julia
that referenced
this pull request
Feb 28, 2017
* close JuliaLang#18320 * Update NEWS.md * Update deprecated.jl * Update deprecated.jl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this synthesizes all of the concerns expressed in #18320