Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use larger interval for pollfd test #14001

Merged
merged 1 commit into from
Nov 17, 2015
Merged

Use larger interval for pollfd test #14001

merged 1 commit into from
Nov 17, 2015

Conversation

nalimilan
Copy link
Member

This prevents frequent failures from happening on build VMs.
It is not clear whether the failure reflects an underlying
bug or not, but having the CI fail randomly doesn't help fixing it.

Fixes or works around #12824

This prevents frequent failures from happening on build VMs.
It is not clear whether the failure reflects an underlying
bug or not, but having the CI fail randomly doesn't help
fixing it.
@tkelman tkelman added the test This change adds or pertains to unit tests label Nov 15, 2015
@ViralBShah
Copy link
Member

cc @amitmurthy

@vtjnash
Copy link
Sponsor Member

vtjnash commented Nov 15, 2015

this change isn't related to the cause of the bug (which is a discrepancy in the elapsed-time estimation), so it likely won't affect the failure rate

@amitmurthy
Copy link
Contributor

Agree with Jameson. Comment out the test since we anyway have #12824 open and tracking the bug ?

@nalimilan
Copy link
Member Author

I'm not sure, but 1) the failure only happens with the 0.002 interval, not the larger ones, and 2) I haven't seen the failure after applying the change. Isn't it likely that the discrepancy only happens for very short intervals?

I'm OK with disabling it too, though.

@amitmurthy
Copy link
Contributor

OK. Can try it out and change the title of #12824 to something like "pollfd interval test fails for small intervals"

nalimilan added a commit that referenced this pull request Nov 17, 2015
Use larger interval for pollfd test
@nalimilan nalimilan merged commit 758e21e into master Nov 17, 2015
@nalimilan nalimilan deleted the nl/pollfd branch November 17, 2015 08:25
@nalimilan
Copy link
Member Author

I've adjusted the title. Let's see whether we see this failure again or not in the next few weeks.

@nalimilan
Copy link
Member Author

You were right, increasing the interval only made the failures less frequent, but they haven't disappeared. I've just seen one with 0.005 <= 0.004910521.

In PR #14074, I comment out the test as you suggested.

@nalimilan
Copy link
Member Author

(FWIW, though it hasn't fixed them, it seems this already reduced the failure rate quite noticeably.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants