Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pollfd test fails for small intervals #12824

Closed
nalimilan opened this issue Aug 27, 2015 · 6 comments
Closed

pollfd test fails for small intervals #12824

nalimilan opened this issue Aug 27, 2015 · 6 comments
Labels
domain:io Involving the I/O subsystem: libuv, read, write, etc. kind:bug Indicates an unexpected problem or unintended behavior test This change adds or pertains to unit tests

Comments

@nalimilan
Copy link
Member

I've seen this failure on two builds at about the same time when creating RPM nightlies for Fedora. Now the tests pass.

This looks like an indication that the build machine was too busy or something similar, but I wonder whether the tolerance should be increased? Having tests fail depending on the workload of builders adds more noise to the test suite results.

If that really indicates a pathological state of the build machine, feel free to close of course.

    From worker 3:       * resolve               in   3.85 seconds
    From worker 2:       * file                  in  18.04 seconds
ERROR: LoadError: On worker 3:
LoadError("/builddir/build/BUILD/julia/test/pollfd.jl",65,ErrorException("test failed: 0.002 <= 0.001800923\n in expression: intvl <= t_elapsed")
 in error at ./error.jl:21
 in default_handler at test.jl:30
 in do_test at test.jl:53
 in pfd_tst_timeout at /builddir/build/BUILD/julia/test/pollfd.jl:59
 in anonymous at task.jl:447)
 in sync_end at ./task.jl:413
 in anonymous at no file:422
 in include_string at loading.jl:233
 in include_from_node1 at ./loading.jl:274
 in runtests at /builddir/build/BUILD/julia/test/testdefs.jl:179
 in anonymous at multi.jl:889
 in run_work_thunk at multi.jl:642
 in anonymous at task.jl:889
while loading /builddir/build/BUILD/julia/test/runtests.jl, in expression starting on line 13
    From worker 3:       * pollfd               Makefile:9: recipe for target 'all' failed
make[1]: *** [all] Error 1
make[1]: Leaving directory '/builddir/build/BUILD/julia/test'
Makefile:516: recipe for target 'test' failed
make: *** [test] Error 2

https://copr-be.cloud.fedoraproject.org/results/nalimilan/julia-nightlies/fedora-rawhide-x86_64/00111484-julia/build.log.gz

@carlobaldassi
Copy link
Member

From the log, the failure seems to be in pollfd, not resolve.

@carlobaldassi carlobaldassi changed the title resolve test failed pollfd test failed Aug 27, 2015
@tkelman tkelman added the test This change adds or pertains to unit tests label Aug 27, 2015
@tkelman
Copy link
Contributor

tkelman commented Aug 27, 2015

has been happening intermittently since #12237 (comment)

@nalimilan
Copy link
Member Author

Seen it again when building official Fedora RPM package:
https://kojipkgs.fedoraproject.org//work/tasks/6543/10866543/build.log

@nalimilan
Copy link
Member Author

Could something be done about this? It's annoying when a test rebuild in the Fedora build farms is marked as failing just because of this random bug.

@JeffBezanson JeffBezanson added kind:bug Indicates an unexpected problem or unintended behavior domain:io Involving the I/O subsystem: libuv, read, write, etc. labels Oct 23, 2015
@nalimilan nalimilan changed the title pollfd test failed pollfd test fails for small intervals Nov 17, 2015
@nalimilan
Copy link
Member Author

#14001 increased the smallest interval from 0.002 to 0.005, as it seems to get rid of the failure on Fedora build VMs. Interestingly, the error message was generally similar to the description above, with an actual time measured of 0.0018. Looks like elapsed time is not measured correctly.

@KristofferC
Copy link
Sponsor Member

Seems obsoleted by #14001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:io Involving the I/O subsystem: libuv, read, write, etc. kind:bug Indicates an unexpected problem or unintended behavior test This change adds or pertains to unit tests
Projects
None yet
Development

No branches or pull requests

5 participants