errors: fix handling of .op in lowering (#44770)

Discovered while running the syntax tests with lines 25-28 of
`jlfrontend.scm` commented out. Turned out we didn't handle `.op`
correctly in neither `check-dotop` nor in `deparse`. This meant we just
got `error: malformed expression` instead of an actually useful error
message.

(cherry picked from commit 9112135)

src/ast.scm

@@ -73,13 +73,15 @@
  ((char? e) (string "'" e "'"))
  ((atom? e) (string e))
  ((eq? (car e) '|.|)
- (string (deparse (cadr e)) '|.|
- (cond ((and (pair? (caddr e)) (memq (caaddr e) '(quote inert)))
- (deparse-colon-dot (cadr (caddr e))))
- ((and (pair? (caddr e)) (eq? (caaddr e) 'copyast))
- (deparse-colon-dot (cadr (cadr (caddr e)))))
- (else
- (string #\( (deparse (caddr e)) #\))))))
+ (if (length= e 2)
+ (string "(." (deparse (cadr e)) ")")
+ (string (deparse (cadr e)) '|.|
+ (cond ((and (pair? (caddr e)) (memq (caaddr e) '(quote inert)))
+ (deparse-colon-dot (cadr (caddr e))))
+ ((and (pair? (caddr e)) (eq? (caaddr e) 'copyast))
+ (deparse-colon-dot (cadr (cadr (caddr e)))))
+ (else
+ (string #\( (deparse (caddr e)) #\)))))))
  ((memq (car e) '(... |'|))
  (string (deparse (cadr e)) (car e)))
  ((or (syntactic-op? (car e)) (eq? (car e) '|<:|) (eq? (car e) '|>:|) (eq? (car e) '-->))
@@ -419,7 +421,7 @@
  (if (dotop-named? e)
  (error (string "invalid function name \"" (deparse e) "\""))
  (if (pair? e)
- (if (eq? (car e) '|.|)
+ (if (and (eq? (car e) '|.|) (length= e 3))
  (check-dotop (caddr e))
  (if (quoted? e)
  (check-dotop (cadr e))))))

test/syntax.jl

@@ -1889,7 +1889,12 @@ f31404(a, b; kws...) = (a, b, kws.data)
 # issue #28992
 macro id28992(x) x end
 @test @id28992(1 .+ 2) == 3
-@test Meta.isexpr(Meta.lower(@__MODULE__, :(@id28992((.+)(a,b) = 0))), :error)
+@test Meta.@lower(.+(a,b) = 0) == Expr(:error, "invalid function name \".+\"")
+@test Meta.@lower((.+)(a,b) = 0) == Expr(:error, "invalid function name \"(.+)\"")
+let m = @__MODULE__
+ @test Meta.lower(m, :($m.@id28992(.+(a,b) = 0))) == Expr(:error, "invalid function name \"$(nameof(m)).:.+\"")
+ @test Meta.lower(m, :($m.@id28992((.+)(a,b) = 0))) == Expr(:error, "invalid function name \"(.$(nameof(m)).+)\"")
+end
 @test @id28992([1] .< [2] .< [3]) == [true]
 @test @id28992(2 ^ -2) == 0.25
 @test @id28992(2 .^ -2) == 0.25