Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnzymeCore extension for parent_job #2281

Merged
merged 9 commits into from
Apr 22, 2024
Merged

Add EnzymeCore extension for parent_job #2281

merged 9 commits into from
Apr 22, 2024

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Mar 5, 2024

Alternative to #2260, depends on EnzymeAD/Enzyme.jl#1328

Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Marking as draft since the dependent PR hasn't been merged yet (to save on CI resources).

@maleadt maleadt marked this pull request as draft March 6, 2024 08:04
@vchuravy vchuravy marked this pull request as ready for review March 17, 2024 17:23
@vchuravy
Copy link
Member Author

Okay this should be ready now.

@maleadt
Copy link
Member

maleadt commented Mar 19, 2024

Looks like NNlib will need an EnzymeCore compat bump for CI to pass here (normally we detect installation issues of downstream packages and soft-fail that job, but here EnzymeCore is only a test dep so the failure happens during Pkg.test).

@vchuravy vchuravy marked this pull request as draft March 19, 2024 10:40
@wsmoses
Copy link
Contributor

wsmoses commented Mar 27, 2024

here's the NNlib bump: FluxML/NNlib.jl#571

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.84%. Comparing base (c5fcd73) to head (0db9773).
Report is 11 commits behind head on master.

Files Patch % Lines
src/initialization.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2281      +/-   ##
==========================================
- Coverage   71.86%   71.84%   -0.02%     
==========================================
  Files         155      155              
  Lines       15020    15022       +2     
==========================================
- Hits        10794    10793       -1     
- Misses       4226     4229       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt marked this pull request as ready for review March 28, 2024 20:41
@maleadt maleadt marked this pull request as draft March 28, 2024 20:41
@maleadt maleadt marked this pull request as ready for review March 29, 2024 09:41
@michel2323
Copy link

This works for JuliaGPU/KernelAbstractions.jl#454 . Can we merge this?

@vchuravy
Copy link
Member Author

vchuravy commented Apr 9, 2024

We need Enzyme.jl v0.12 to be released. Otherwise we make Enzyme and CUDA uninstallable together.

@michel2323
Copy link

Enzyme v0.12 is released Let me know if there's something I can do.

@wsmoses
Copy link
Contributor

wsmoses commented Apr 20, 2024

@vchuravy these test failures seem unrelated. good to go?

@maleadt
Copy link
Member

maleadt commented Apr 22, 2024

Yeah, the sorting failure is #2331. I've restarted the job.

@vchuravy vchuravy merged commit 6b82b3e into master Apr 22, 2024
1 check passed
@vchuravy vchuravy deleted the vc/enzyme_core branch April 22, 2024 18:54
wsmoses pushed a commit to wsmoses/CUDA.jl that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants