Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnzymeCore is an unconditional dependency. #2380

Closed
maleadt opened this issue May 15, 2024 · 4 comments
Closed

EnzymeCore is an unconditional dependency. #2380

maleadt opened this issue May 15, 2024 · 4 comments
Assignees
Labels
bug Something isn't working extensions Stuff about package extensions.

Comments

@maleadt
Copy link
Member

maleadt commented May 15, 2024

I just noticed that #2281 also added EnzymeCore as a full dependency, next to it being a weak dependency. That defeats most of the point of it being a package extension. I guess it can just be removed from being a full dependency?

@wsmoses This blocks a 5.3.4 backport release, which shouldn't introduce new dependencies.

@maleadt maleadt added bug Something isn't working extensions Stuff about package extensions. labels May 15, 2024
@vchuravy
Copy link
Member

Hm that's the default extension pattern to make things work prior to 1.10

We can drop it of course, but it will gate functionality on that.

@maleadt
Copy link
Member Author

maleadt commented May 15, 2024

Hm that's the default extension pattern to make things work prior to 1.10

I don't think it is? Pre 1.9 we used Requires, which doesn't require a dependency
https://pkgdocs.julialang.org/v1/creating-packages/#Backwards-compatibility

@wsmoses
Copy link
Contributor

wsmoses commented May 15, 2024

I think it should just be removable then?

@maleadt
Copy link
Member Author

maleadt commented May 15, 2024

Pre 1.9 we used Requires, which doesn't require a dependency

For completeness:

@require EnzymeCore = "f151be2c-9106-41f4-ab19-57ee4f262869" begin
include("../ext/EnzymeCoreExt.jl")
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working extensions Stuff about package extensions.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants