-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EnzymeCore is an unconditional dependency. #2380
Comments
Hm that's the default extension pattern to make things work prior to 1.10 We can drop it of course, but it will gate functionality on that. |
I don't think it is? Pre 1.9 we used Requires, which doesn't require a dependency |
I think it should just be removable then? |
For completeness: Lines 158 to 160 in a0b1b8d
|
I just noticed that #2281 also added EnzymeCore as a full dependency, next to it being a weak dependency. That defeats most of the point of it being a package extension. I guess it can just be removed from being a full dependency?
@wsmoses This blocks a 5.3.4 backport release, which shouldn't introduce new dependencies.
The text was updated successfully, but these errors were encountered: