Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement promotion rules for CategoricalArray #384

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Commits on Mar 11, 2022

  1. Implement promotion rules for CategoricalArray

    These are rarely needed, but an exception is when storing `CategoricalArray`
    objects within arrays, as the `[a1, a2]` syntax uses promotion to choose
    the element type of the result. This previously failed as it hit a fallback
    `promote_result` method defined for `AbstractArray` in Base in range.jl,
    which tried to convert `CategoricalArray`s to `Array` by calling nonexistent
    `convert` methods for `CategoricalValue`.
    nalimilan committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    284da9c View commit details
    Browse the repository at this point in the history