Implement promotion rules for CategoricalArray
#384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are rarely needed, but an exception is when storing `CategoricalArray` objects within arrays, as the `[a1, a2]` syntax uses promotion to choose the element type of the result. This previously failed as it hit a fallback `promote_result` method defined for `AbstractArray` in Base in range.jl, which tried to convert `CategoricalArray`s to `Array` by calling nonexistent `convert` methods for `CategoricalValue`.
bkamins
approved these changes
Mar 11, 2022
|
Looks good, but some other tests now started to fail. |
|
Failures are fixed by #385, though we'll probably need more promotion rules to handle better the combination of |
|
Thank you! |
nalimilan
added a commit
that referenced
this pull request
Mar 16, 2022
PR #384 added promotion rules that recursively promote the eltype and reftype, but this has the drawback that the resulting type is often not a supertype of the input types, forcing a conversion to a `CategoricalArray` which may have a `Union` type. Instead, do the same as `Array` and `AbstractArray` fallbacks, which simply call `promote_typejoin` if eltypes do not match.
nalimilan
added a commit
that referenced
this pull request
Mar 17, 2022
PR #384 added promotion rules that recursively promote the eltype and reftype, but this has the drawback that the resulting type is often not a supertype of the input types, forcing a conversion to a `CategoricalArray` which may have a `Union` type. Instead, do the same as `Array` and `AbstractArray` fallbacks, which simply call `promote_typejoin` if eltypes do not match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are rarely needed, but an exception is when storing
CategoricalArrayobjects within arrays, as the[a1, a2]syntax uses promotion to choose the element type of the result. This previously failed as it hit a fallbackpromote_resultmethod defined forAbstractArrayin Base in range.jl, which tried to convertCategoricalArrays toArrayby calling nonexistentconvertmethods forCategoricalValue.Fixes #383.